Fix #181:Introduce pretty print and pager output for challenges #197

RohanSreelesh · 2019-12-09T05:13:14Z

The table that is displayed when the command evalai challenges is used has the respective colors:
1.ID-White
2.Title-Yellow
3.Short Description-Cyan
4.Creator-White
5.Start date- Green
6.End date -Red

It also has pager output enabled so that the command line output is not overwhelming

pushkalkatara · 2019-12-09T06:37:44Z

Hi @RohanSreelesh The build is failing.

Please add termcolor as a dependency and resolve flake8 formats.

pushkalkatara · 2019-12-09T07:06:12Z

requirements.txt

+responses==0.9.0
+validators==0.12.2
+termcolor==1.1.0
+


Please remove this extra line.

pushkalkatara · 2019-12-09T07:07:58Z

To resolve flake8 issues:

Locally install flake8 using pip python -m pip install flake8
run the command - flake8 ~/dir/evalai-cli
it would list some errors, resolve accordingly.

Ram81 · 2019-12-09T07:28:59Z

evalai/utils/challenges.py

@@ -1,10 +1,10 @@
 import json
 import requests
 import sys
-
+from termcolor import colored


@RohanSreelesh please move this to last import after datetime. We follow alphabetical order for imports

Ram81 · 2019-12-09T07:29:18Z

evalai/utils/challenges.py

 from bs4 import BeautifulSoup
 from beautifultable import BeautifulTable
-from click import echo, style
+from click import echo, style, echo_via_pager


move style after echo_via_pager

ok I have moved it to the end and changed style and eco_via_pager

pushkalkatara · 2019-12-09T08:05:22Z

requirements.txt

-coveralls==1.3.0
-docker==3.6.0
-flake8==3.0.4
-lxml==4.2.1


@RohanSreelesh Why is lxml removed as a dependency in this commit?

My build wasnt installing , then @yashdusing on gitter suggested removing this from requirements and setup.py after which I was able to install it successfully
The error can be found here https://imgur.com/g4wefJP

Some development libraries are missing in the python package related to lxml, thus the package was not installing. You can find more details here.

We cannot remove it from the requirements as it would break some other parts of the code(for example, the build fails as the lmxl based tests are not passing).

The issue exists on windows due to the version of lxml (please refer to the second answer on the link about. maybe you could update the version of lxml in requirements.txt and try reinstalling on windows to resolve the issue.)

I understand , I had done the solutions given in the link including the second answer but the build still didnt work for me unfortunately. I'll add it back

I added lxml back into requirements and setup.py but the build is still failing @pushkalkatara

The build is failing due to some more issues. You can get all the details here.

flake8 error

the test outputs don't match (you need to update the tests also.)

RohanSreelesh · 2019-12-09T08:37:51Z

removed echo_via_pager as it isnt giving consistent outputs

RohanSreelesh · 2019-12-09T14:19:06Z

Update to tests based on the changes made in the above code

pushkalkatara · 2019-12-09T15:00:57Z

Good job @RohanSreelesh . Looks good to me. The output -

yashdusing · 2019-12-09T15:05:16Z

Also, @RohanSreelesh check for the case for the descriptions are too large or too small. I guess it would be okay to truncate the text after a certain limit. Also check for empty string

pushkalkatara · 2019-12-09T15:07:27Z

@yashdusing Another student is working on that task and there's an open PR for the same - #183

RohanSreelesh · 2019-12-10T14:14:22Z

@pushkalkatara @yashdusing Is my work regarding this done? if so how may I proceed as my task on gci is still in submitted state. Thanks

yashdusing · 2019-12-10T14:37:38Z

@RohanSreelesh try synchronising the file by using the 2 files from an earlier build. Then, make changes to it

RohanSreelesh · 2019-12-10T14:51:36Z

@RohanSreelesh try synchronising the file by using the 2 files from an earlier build. Then, make changes to it

Thanks @yashdusing that worked and now it shows only 1 line as newly added

yashdusing · 2019-12-10T14:52:18Z

@RohanSreelesh add the missing line as mentioned.

RohanSreelesh · 2019-12-10T14:54:04Z

@RohanSreelesh add the missing line as mentioned.

which line @yashdusing ? I have added termcolor in both setup.py and requirements

yashdusing · 2019-12-10T15:34:34Z

@RohanSreelesh line 34 in setup.py. Please check

yashdusing · 2019-12-10T15:42:20Z

LGTM 👍
@Ram81 @pushkalkatara please verify

pushkalkatara · 2019-12-10T20:51:38Z

Looks good to me too. Good job @RohanSreelesh .

RishabhJain2018

LGTM :)
Good work @RohanSreelesh 🎉

Thanks, @pushkalkatara @yashdusing @Ram81 for the quick reviews

…oud-CV#197) * pretty print task * Add files via upload * Update requirements.txt * Add files via upload * Add files via upload * Delete challenges.py * Update challenges.py * Update requirements.txt * Update setup.py * Update challenges.py * Update challenges.py * Update challenges.py * Update challenges.py * Update requirements.txt * Update setup.py * trying to add test * fixed flask8 errors * flake8 errors * changed str(table) to table * Update test_challenges.py * Update test_challenges.py * Update test_auth.py * Update test_auth.py * Update requirements.txt * Add files via upload * Update requirements.txt * Update requirements.txt * Add files via upload * Add files via upload * Update requirements.txt * Add files via upload * Update setup.py * Update setup.py

pretty print task

5fabd6d

RohanSreelesh mentioned this pull request Dec 9, 2019

[GCI-2019] Pretty print CLI output on terminal. #181

Closed

Add files via upload

4184fa5

pushkalkatara reviewed Dec 9, 2019

View reviewed changes

requirements.txt Outdated

responses==0.9.0

validators==0.12.2

termcolor==1.1.0

Copy link

pushkalkatara Dec 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this extra line.

Update requirements.txt

07a7309

RohanSreelesh added 6 commits December 9, 2019 12:48

Add files via upload

35aaa41

Add files via upload

f164cf6

Delete challenges.py

01dd808

Update challenges.py

7a8fba4

Update requirements.txt

c93df7f

Update setup.py

17f1573

Ram81 requested changes Dec 9, 2019

View reviewed changes

RohanSreelesh added 3 commits December 9, 2019 13:02

Update challenges.py

ace5eda

Update challenges.py

5d7817b

Update challenges.py

876ca16

pushkalkatara reviewed Dec 9, 2019

View reviewed changes

Update challenges.py

c5c7358

RohanSreelesh added 10 commits December 9, 2019 14:24

Update requirements.txt

8360b33

Update setup.py

c91ac2d

trying to add test

f1a138b

fixed flask8 errors

94cd77d

flake8 errors

2792729

changed str(table) to table

f253581

Update test_challenges.py

814ecfe

Update test_challenges.py

f28c567

Update test_auth.py

53613ef

Update test_auth.py

9a32a59

RohanSreelesh added 4 commits December 10, 2019 19:59

Update requirements.txt

41d8b11

Add files via upload

0ca7510

Update requirements.txt

67eb9c3

Update requirements.txt

4007d16

RohanSreelesh added 5 commits December 10, 2019 20:14

Add files via upload

e7d5556

Add files via upload

f12a086

Update requirements.txt

1ca6ff4

Add files via upload

c771e65

Update setup.py

e72fd1e

Update setup.py

18caa2f

RishabhJain2018 approved these changes Dec 15, 2019

View reviewed changes

RishabhJain2018 merged commit c744798 into Cloud-CV:master Dec 15, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #181:Introduce pretty print and pager output for challenges #197

Fix #181:Introduce pretty print and pager output for challenges #197

RohanSreelesh commented Dec 9, 2019

pushkalkatara commented Dec 9, 2019

pushkalkatara Dec 9, 2019

pushkalkatara commented Dec 9, 2019

Ram81 Dec 9, 2019

Ram81 Dec 9, 2019

RohanSreelesh Dec 9, 2019 •

edited

Loading

pushkalkatara Dec 9, 2019

RohanSreelesh Dec 9, 2019

pushkalkatara Dec 9, 2019

RohanSreelesh Dec 9, 2019

RohanSreelesh Dec 9, 2019

pushkalkatara Dec 9, 2019

RohanSreelesh commented Dec 9, 2019

RohanSreelesh commented Dec 9, 2019

pushkalkatara commented Dec 9, 2019

yashdusing commented Dec 9, 2019

pushkalkatara commented Dec 9, 2019

RohanSreelesh commented Dec 10, 2019 •

edited

Loading

yashdusing commented Dec 10, 2019

RohanSreelesh commented Dec 10, 2019

yashdusing commented Dec 10, 2019

RohanSreelesh commented Dec 10, 2019 •

edited

Loading

yashdusing commented Dec 10, 2019

yashdusing commented Dec 10, 2019

pushkalkatara commented Dec 10, 2019

RishabhJain2018 left a comment

Fix #181:Introduce pretty print and pager output for challenges #197

Fix #181:Introduce pretty print and pager output for challenges #197

Conversation

RohanSreelesh commented Dec 9, 2019

pushkalkatara commented Dec 9, 2019

Choose a reason for hiding this comment

pushkalkatara commented Dec 9, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RohanSreelesh Dec 9, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RohanSreelesh commented Dec 9, 2019

RohanSreelesh commented Dec 9, 2019

pushkalkatara commented Dec 9, 2019

yashdusing commented Dec 9, 2019

pushkalkatara commented Dec 9, 2019

RohanSreelesh commented Dec 10, 2019 • edited Loading

yashdusing commented Dec 10, 2019

RohanSreelesh commented Dec 10, 2019

yashdusing commented Dec 10, 2019

RohanSreelesh commented Dec 10, 2019 • edited Loading

yashdusing commented Dec 10, 2019

yashdusing commented Dec 10, 2019

pushkalkatara commented Dec 10, 2019

RishabhJain2018 left a comment

Choose a reason for hiding this comment

RohanSreelesh Dec 9, 2019 •

edited

Loading

RohanSreelesh commented Dec 10, 2019 •

edited

Loading

RohanSreelesh commented Dec 10, 2019 •

edited

Loading