Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added pretty logging and echo via pager GCI challenge #183

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

neelr
Copy link

@neelr neelr commented Dec 4, 2019

Hi! I added pretty logging to challenge file for my task! I added echo via page too for the tables!

@pushkalkatara
Copy link

pushkalkatara commented Dec 4, 2019

Hi @neelr Thanks for the PR. The build is failing due to two reasons -

  1. Flake8 formatting error.
  2. Output format doesn't match with the test's output.

@pushkalkatara
Copy link

@neelr

  1. To find out where flake8 problem exists, installing flake8 on your computer and running it on your branch would list all the formatting requirements which are missing. You can install it using python -m pip install flake8 and run on the repo as flake8 ~/dir/evalai-cli.

  2. It is related to the pytests which are written to check the output of a CLI command. But while running the task, the output is NULL as reported in the build. (the ' ' symbol).

@@ -253,8 +253,8 @@ def display_participated_or_hosted_challenges(
filter(
lambda challenge: validate_date_format(
challenge["end_date"]
)
> datetime.now()
) >

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neelr flake8 is giving out this error

evalai-cli/evalai/utils/challenges.py:256:23: W504 line break after binary operator

We can find it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants