Rename RCTWKWebView to CRAWKWebView to avoid symbol clash with RN 0.57 #195
Conversation
…NSHTTPURLResponse, so headers and status code might not be available
|
We really need this in master since it's not possible to upgrade to RN 0.57. And RN < 0.57 doesn't work with Xcode 10 |
|
+1 |
| if([navigationResponse.response isKindOfClass:[NSHTTPURLResponse class]]){ | ||
| headers = ((NSHTTPURLResponse *)navigationResponse.response).allHeaderFields; | ||
| statusCode = ((NSHTTPURLResponse *)navigationResponse.response).statusCode; | ||
| } |
There was a problem hiding this comment.
How is this part related to the symbol clash and rename?
There was a problem hiding this comment.
RN 0.57 duplicate class RCTWebView RCTWebViewManager. Error will occur when Xcode build.
There was a problem hiding this comment.
I know about the duplicate symbol error. But the specific lines of code I commented on do not relate to those symbols. It looks like a different commit accidentally came along for the ride.
There was a problem hiding this comment.
I think this happens to be a fix for #199
There was a problem hiding this comment.
I think this happens to be a fix for #199
|
I am on vacation now and I will merge it after I am back |
|
on npm now: 2.0.0 I have also renamed files and updated the example project to RN 0.57. |
Fixes #194