Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatible with React Native 0.57 #194

Closed
DimitryDushkin opened this issue Sep 13, 2018 · 2 comments
Closed

Incompatible with React Native 0.57 #194

DimitryDushkin opened this issue Sep 13, 2018 · 2 comments

Comments

@DimitryDushkin
Copy link
Contributor

DimitryDushkin commented Sep 13, 2018 •
edited
Loading

In 57 WkWebView support has been added and they using exact same file names and classes RCTWKWebView.m(h) so it won't compile now.

Seems like we should rename files and classes in this repo to be able to compile with React Native 0.57.
@headlessme headlessme mentioned this issue Sep 17, 2018
Merged
@jamonholmgren
Copy link

Per this issue, I'd suggest looking at the new community-supported react-native-webview. While we aren't at feature parity with react-native-wkwebview (since we need to support Android and iOS as equally as possible), we are open to community PRs to bring in functionality you need.

https://github.com/react-native-community/react-native-webview

@insraq
Copy link
Contributor

insraq commented Sep 30, 2018

I will merge the PR after I am back from vacation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DimitryDushkin @insraq @jamonholmgren