Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV: Messages about modifiers are warnings until 2025 #60

Merged
merged 1 commit into from
Nov 7, 2024
Merged

CSV: Messages about modifiers are warnings until 2025 #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions src/versions/2.0/csv.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,14 +502,15 @@ function validateModifierRow(
" for wide format when a modifier is encoded without an item or service"
).length > 0
) {
errors.push(
csvErr(
errors.push({
...csvErr(
index,
columns.indexOf(modifierRequiredFields[0]),
modifierRequiredFields[0],
ERRORS.MODIFIER_EXTRA_INFO()
)
)
),
warning: !enforce2025,
})
}
} else {
const modifierRequiredFields = [
Expand All @@ -527,14 +528,15 @@ function validateModifierRow(
" for tall format when a modifier is encoded without an item or service"
).length > 0
) {
errors.push(
csvErr(
errors.push({
...csvErr(
index,
columns.indexOf(modifierRequiredFields[0]),
modifierRequiredFields[0],
ERRORS.MODIFIER_EXTRA_INFO()
)
)
),
warning: !enforce2025,
})
}
}

Expand Down
2 changes: 2 additions & 0 deletions test/2.0/csv.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -942,6 +942,7 @@ test("validateRow tall conditionals", (t) => {
invalidModifierErrors[0].message,
"If a modifier is encoded without an item or service, then a description and one of the following is the minimum information required: additional_payer_notes, standard_charge | negotiated_dollar, standard_charge | negotiated_percentage, or standard_charge | negotiated_algorithm."
)
t.is(invalidModifierErrors[0].warning, !enforceConditionals)
const modifierWithNotesRow = {
...basicRow,
"code | 1": "",
Expand Down Expand Up @@ -1642,6 +1643,7 @@ test("validateRow wide conditionals", (t) => {
invalidModifierErrors[0].message,
"If a modifier is encoded without an item or service, then a description and one of the following is the minimum information required: additional_payer_notes, standard_charge | negotiated_dollar, standard_charge | negotiated_percentage, or standard_charge | negotiated_algorithm."
)
t.is(invalidModifierErrors[0].warning, !enforceConditionals)
const modifierWithGenericNotesRow = {
...basicRow,
"code | 1": "",
Expand Down
Loading