CSV: Messages about modifiers are warnings until 2025 #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When validating a CSV, the error that results if a modifier is missing necessary additional information is marked as a warning if the system date is before 2025.
shaselton-usds
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It is not yet 2025, but messages regarding modifier additional information are marked as errors, not warnings, when validating a CSV.
Solution
When validating a CSV, the error that results if a modifier is missing necessary additional information is marked as a warning if the system date is before 2025.
Test Plan
Test cases for modifier additional information are updated to check the warning flag of the error object.