Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend refactoring: round 3 #249

Merged
merged 2 commits into from
Dec 15, 2021
Merged

Frontend refactoring: round 3 #249

merged 2 commits into from
Dec 15, 2021

Conversation

msm-code
Copy link
Contributor

@msm-code msm-code commented Dec 13, 2021

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running mquery, and testing changed functionality (if applicable)
  • I've added automated tests for my change (if applicable, optional)
  • I've updated documentation to reflect my change (if applicable)

What is the current behaviour?
Last round of refactoring for #248

What is the new behaviour?
Reduced the amount of code and simplified the rest. The change is less significant than I've thought, because apparently there's a lot of inherent complexity in the UI.

I think this solves the issue, especially after reformatting (#238 )

Test plan
Ensure that mquery works and nothing breaks during the normal use.

Closing issues

fixes #237

@msm-code msm-code requested a review from nazywam December 13, 2021 18:35
@msm-code
Copy link
Contributor Author

The class I'm most proud of is FilteringTitle, because I had to actually write some frontend code (took me 30 minutes of browsing random SO threads).

@msm-code msm-code merged commit df0ddcc into master Dec 15, 2021
@msm-code msm-code linked an issue Dec 19, 2021 that may be closed by this pull request
4 tasks
@msm-code msm-code deleted the refactor/components3 branch December 24, 2021 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify the frontend code
2 participants