Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the frontend code #237

Closed
4 tasks
msm-code opened this issue Nov 30, 2021 · 0 comments · Fixed by #249
Closed
4 tasks

Simplify the frontend code #237

msm-code opened this issue Nov 30, 2021 · 0 comments · Fixed by #249

Comments

@msm-code
Copy link
Contributor

Feature Category

  • Correctness
  • User Interface / User Experience
  • Performance
  • Other (please explain) - maintenance

Describe the problem

When did the UI code get so complex? I must've looked the other way. We should investigate how to simplify it again, otherwise we will scare new contributors away from contributing their work.

Describe the solution you'd like

It's hard to give a quantitive solution, but there are 48 (!) javascript files and I find it hard to justify:

$ find -type f -name "*.js" | wc -l
48

Probably some of these could be inlined and/or combined into one?

Describe alternatives you've considered

Maybe I am wrong and the UI is just more complex than I rememver. I'm also not a frontend developer. But I suspect there is some overengineering involved here.

@msm-code msm-code linked a pull request Dec 19, 2021 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant