SignalReceiver PR

lib/SignalReceiver/src/App.cpp

@@ -224,7 +224,7 @@ void App::setup()
                         m_motorSpeedTimer.start(SEND_MOTOR_SPEED_TIMER_INTERVAL);
                         m_statusTimer.start(SEND_STATUS_TIMER_INTERVAL);
 
-                        /**
+                        /*
                          * Asyncronous time amount to avoid a syncronization (a time amount equal to a multiple
                          * of 5) between the RU odometry callback and traffic processing.
                          *

lib/SignalReceiver/src/App.h

@@ -25,8 +25,8 @@
     DESCRIPTION
 *******************************************************************************/
 /**
- * @brief  RemoteControl application
- * @author Gabryel Reyes <gabryelrdiaz@gmail.com>
+ * @brief  SignalReceiver application
+ * @author Paul Gramescu <paul.gramescu@gmail.com>
  *
  * @addtogroup Application
  *
@@ -206,10 +206,10 @@ class App
     SimpleTimer m_statusTimeoutTimer;
 
     /** Sending color Id only when near IE. */
-    bool m_isListening = false;
+    bool m_isListening;
 
     /** Used for unique subscription. */
-    bool m_isSubscribed = false;
+    bool m_isSubscribed;
 
     /** Save current deserialized value of COLOR ID. */
     Color clr;

lib/SignalReceiver/src/CoordinateHandler.h

@@ -62,7 +62,11 @@
 class CoordinateHandler
 {
 public:
-    /** The CoordinateHandler instance. */
+    /**
+     * Get the coordinate handler instance.
+     *
+     * @return the instance of coordinate handler.
+     */
     static CoordinateHandler& getInstance()
     {
         static CoordinateHandler instance;

lib/SignalReceiver/src/SerialMuxChannels.h

@@ -99,7 +99,7 @@ namespace SMPChannelPayload
     /** Remote control commands. */
     typedef enum : uint8_t
     {
-        CMD_ID_IDLE = 0,                /**< Nothing to do. */
+        CMD_ID_IDLE = 0U,               /**< Nothing to do. */
         CMD_ID_START_LINE_SENSOR_CALIB, /**< Start line sensor calibration. */
         CMD_ID_START_MOTOR_SPEED_CALIB, /**< Start motor speed calibration. */
         CMD_ID_REINIT_BOARD,            /**< Re-initialize the board. Required for webots simulation. */
@@ -112,7 +112,7 @@ namespace SMPChannelPayload
     /** Remote control command responses. */
     typedef enum : uint8_t
     {
-        RSP_ID_OK = 0,  /**< Command successful executed. */
+        RSP_ID_OK = 0U, /**< Command successful executed. */
         RSP_ID_PENDING, /**< Command is pending. */
         RSP_ID_ERROR    /**< Command failed. */
 
@@ -121,8 +121,8 @@ namespace SMPChannelPayload
     /** Status flags. */
     typedef enum : uint8_t
     {
-        STATUS_FLAG_OK = 0, /**< Everything is fine. */
-        STATUS_FLAG_ERROR   /**< Something is wrong. */
+        STATUS_FLAG_OK = 0U, /**< Everything is fine. */
+        STATUS_FLAG_ERROR    /**< Something is wrong. */
 
     } Status; /**< Status flag */
 

lib/SignalReceiver/src/TrafficHandler.h

@@ -25,7 +25,7 @@
     DESCRIPTION
 *******************************************************************************/
 /**
- * @brief The green light phase realization.
+ * @brief The traffic handler realization.
  * @author Paul Gramescu <[email protected]>
  *
  * @addtogroup Application
@@ -158,16 +158,6 @@ class TrafficHandler
         lockedOnto = "";
     }
 
-    /** Traffic handler constructor. */
-    TrafficHandler() : m_colorID(0U)
-    {
-    }
-
-    /** Traffic handler deconstructor. */
-    ~TrafficHandler()
-    {
-    }
-
 private:
     /** Max number of elements in the list. */
     static const uint8_t MAX_ELEMENTS = 10;
@@ -184,6 +174,16 @@ class TrafficHandler
     /** List of infrastructure elements. */
     TrafficElement listOfElements[MAX_ELEMENTS];
 
+    /** Traffic handler constructor. */
+    TrafficHandler() : m_colorID(0U)
+    {
+    }
+
+    /** Traffic handler deconstructor. */
+    ~TrafficHandler()
+    {
+    }
+
     TrafficHandler(const TrafficHandler& state);            /**< Copy construction of an instance. */
     TrafficHandler& operator=(const TrafficHandler& state); /**< Assignment of an instance. */
 };