SignalReceiver PR #88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgraded to SMP 2.1.0
gabryelreyes
requested changes
Feb 7, 2024
gabryelreyes
reviewed
Feb 7, 2024
There was a problem hiding this comment.
@BlueAndi @KaiGlaesker @NTDavidS Looks good to me. Now there are only files relevant to the Application. Style and documentation should be mostly correct now.
For me its ok as well, my focus was mainly that other Apps were not touched. |
KaiGlaesker
reviewed
Feb 9, 2024
added 6 commits
February 12, 2024 09:06
BrndSchndr
reviewed
Feb 29, 2024
BrndSchndr
approved these changes
Mar 5, 2024
|
@paulgrammy Can you fix the conflicting files? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features:
SignalReceiver is a base of RemoteControl
If position and orientation information have been received through settingsCallback, the app will save them in a list of traffic participants
this list is later processed while the robot is driving
once the robot points towards and is close to the given position of the IE, it sends the last color sent by the IE through SMP to RU
designed to work alongside the DCS app EndlessRun
Sorry again for the big PR