Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI failing because of Ubuntu update #7720

Merged
merged 6 commits into from
Jan 9, 2025
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/build-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ jobs:
hookdocs:
runs-on: ubuntu-latest
steps:
- uses: actions/setup-node@v4
with:
node-version: 18
- uses: actions/checkout@v4
- name: npm install, and build docs
run: |
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ jobs:
name: Plugin Build
runs-on: ubuntu-latest
steps:
- uses: actions/setup-node@v4
with:
node-version: 18
- uses: actions/checkout@v4
- name: Get npm cache directory
id: npm-cache
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/dependencies-report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ jobs:
runs-on: ubuntu-latest
name: Build trunk for Dependencies Report
steps:
- uses: actions/setup-node@v4
with:
node-version: 18
- uses: actions/checkout@v4
with:
ref: trunk
Expand Down Expand Up @@ -53,6 +56,9 @@ jobs:
name: WordPress Dependencies Report
runs-on: ubuntu-latest
steps:
- uses: actions/setup-node@v4
with:
node-version: 18
- uses: actions/checkout@v4
- name: Get npm cache directory
id: npm-cache
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ jobs:
timeout-minutes: 15
runs-on: ubuntu-latest
steps:
- uses: actions/setup-node@v4
with:
node-version: 18

- name: Checkout code
uses: actions/checkout@v4

Expand Down
9 changes: 9 additions & 0 deletions .github/workflows/js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ jobs:
name: JS Linting
runs-on: ubuntu-latest
steps:
- uses: actions/setup-node@v4
with:
node-version: 18
- uses: actions/checkout@v4
- uses: actions/cache@v4
with:
Expand All @@ -29,6 +32,9 @@ jobs:
name: TypeScript Checking
runs-on: ubuntu-latest
steps:
- uses: actions/setup-node@v4
with:
node-version: 18
- uses: actions/checkout@v4
- uses: actions/cache@v4
with:
Expand All @@ -47,6 +53,9 @@ jobs:
name: JS Testing
runs-on: ubuntu-latest
steps:
- uses: actions/setup-node@v4
with:
node-version: 18
# clone the repository
- uses: actions/checkout@v4
- uses: actions/cache@v4
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/php.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,10 @@ jobs:
- 3306:3306
options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=5
steps:
- name: Install SVN
run: |
sudo apt update
sudo apt install subversion
- name: Checkout code
uses: actions/checkout@v4

Expand Down
Empty file added test
Empty file.
3 changes: 2 additions & 1 deletion tests/e2e-playwright/pages/admin/courses/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,8 @@ export default class CoursesPage extends PostType {
this.wizardModal = new WizardModal( wizardLocator );

this.createCourseButton = page.locator(
'a.page-title-action[href$="post-new.php?post_type=course"]:has-text("New Course"):visible'
'a.page-title-action[href$="post-new.php?post_type=course"]',
{ hasText: /^New Course$/ }
);

this.courseOutlineBlock = new CourseOutline( page );
Expand Down
Loading