Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI failing because of Ubuntu update #7720

Merged
merged 6 commits into from
Jan 9, 2025
Merged

Fix CI failing because of Ubuntu update #7720

merged 6 commits into from
Jan 9, 2025
+31 −1

Conversation

m1r0
Copy link
Member

@m1r0 m1r0 commented Jan 8, 2025 •
edited
Loading

Resolves #7719

The CI started failing because of a recent Github Actions Ubuntu update - actions/runner-images#10636.

Proposed Changes

  • Install the subversion package which is missing in Ubuntu 24.04.
  • Switch back to Node 18. The default is Node 20 in the new Ubuntu version.
  • Fix E2E tests strict mode violation causing flakiness.

Testing Instructions

The CI should be passing.

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • Code is tested on the minimum supported PHP and WordPress versions

@m1r0 m1r0 closed this Jan 8, 2025
@m1r0 m1r0 deleted the test/e2e branch January 8, 2025 15:48
@m1r0 m1r0 restored the test/e2e branch January 8, 2025 16:34
@m1r0 m1r0 reopened this Jan 8, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

Test the previous changes of this PR with WordPress Playground.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

Test the previous changes of this PR with WordPress Playground.

@m1r0 m1r0 self-assigned this Jan 9, 2025
@m1r0 m1r0 added this to the 4.24.5 milestone Jan 9, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

Test the previous changes of this PR with WordPress Playground.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

Test the previous changes of this PR with WordPress Playground.

@m1r0 m1r0 changed the title Testing CI Fix CI failing because of Ubuntu update Jan 9, 2025
@m1r0 m1r0 marked this pull request as ready for review January 9, 2025 12:40
@m1r0 m1r0 requested a review from donnapep January 9, 2025 12:40
@m1r0 m1r0 mentioned this pull request Jan 9, 2025
Closed
donnapep
donnapep previously approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@donnapep donnapep left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo! Thanks! Looks like we just need to remove the test file and this is good.

I'll also create an issue for updating Sensei / Pro to Node 20.x and npm to 10.x to match WordPress Core.

This was referenced Jan 9, 2025
Closed
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

Test the previous changes of this PR with WordPress Playground.

@m1r0 m1r0 merged commit 685fd00 into trunk Jan 9, 2025
22 checks passed
@m1r0 m1r0 deleted the test/e2e branch January 9, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donnapep donnapep donnapep left review comments

Assignees

@m1r0 m1r0

Labels
No Changelog
Projects
None yet
Milestone
4.24.5
Development

Successfully merging this pull request may close these issues.

Fix failing CI
2 participants
@m1r0 @donnapep