Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make getLatestSnapshot() and removeState() member functions of Node #44

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Make getLatestSnapshot() and removeState() member functions of Node #44

merged 1 commit into from
Apr 17, 2024

Conversation

linh2931
Copy link
Member

Move getLatestSnapshot() and removeState() out from nodeos_irreversible_mode_test.py, nodeos_snapshot_diff_test.py, and ship_streamer_test.py; make them as member functions of Node for reuse.

Resolved #43

@linh2931 linh2931 requested review from heifner and greg7mdp April 17, 2024 15:40
@ericpassmore
Copy link
Contributor

Note:start
group: CLEANCODE
category: TEST
summary: Consolidate and cleanup duplicate getLatestSnapshot() and removeState() functions.
Note:end

@linh2931 linh2931 merged commit 608464d into savanna Apr 17, 2024
36 checks passed
@linh2931 linh2931 deleted the getLatestSnapshot branch April 17, 2024 18:18
@arhag arhag linked an issue Apr 17, 2024 that may be closed by this pull request
Make getLatestSnapshot and removeState member functions in TestHarness's Node.py #43
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heifner heifner heifner approved these changes

@greg7mdp greg7mdp greg7mdp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make getLatestSnapshot and removeState member functions in TestHarness's Node.py
4 participants
@linh2931 @ericpassmore @greg7mdp @heifner