Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make getLatestSnapshot and removeState member functions in TestHarness's Node.py #43

Closed
linh2931 opened this issue Apr 17, 2024 · 0 comments · Fixed by #44
Closed

Make getLatestSnapshot and removeState member functions in TestHarness's Node.py #43

linh2931 opened this issue Apr 17, 2024 · 0 comments · Fixed by #44
Assignees
@linh2931
Labels
👍 lgtm

Comments

@linh2931
Copy link
Member

While working on writing a snapshot test for Savanna transition, I noticed getLatestSnapshot and removeState were implemented in nodeos_irreversible_mode_test.py, nodeos_snapshot_diff_test.py, and ship_streamer_test.py. One of the implementation missed the snapshot schedule config check.

We should move those two functions to Node class so that they can be reused by different tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linh2931 linh2931

Labels
👍 lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make getLatestSnapshot() and removeState() member functions of Node AntelopeIO/spring
2 participants
@arhag @linh2931