Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix how block_states are constructed for transition to contain correct validation tree data #32

Merged
merged 5 commits into from
Apr 16, 2024
Merged

Fix how block_states are constructed for transition to contain correct validation tree data #32

merged 5 commits into from
Apr 16, 2024

Conversation

linh2931
Copy link
Member

Fixed the problem that action_mroots was not constructed when Transition blocks were created starting from the Savanna Genesis block.

Added asserts to valid_t to disallow empty action_mroot and strong_digest.

Resolved #31

@linh2931 linh2931 requested review from greg7mdp and heifner April 16, 2024 01:57
@linh2931 linh2931 merged commit 78f42de into savanna Apr 16, 2024
36 checks passed
@linh2931 linh2931 deleted the fix_empty_action_mroot branch April 16, 2024 14:41
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: INTERNALS
summary: Capture the Savanna action_mroots when constructing transition block_states. Includes validation logic to prevent block_state from being build when essential data is missing.
Note:end

@arhag arhag linked an issue Apr 17, 2024 that may be closed by this pull request
Fix how block_states are constructed for transition to contain correct validation tree data #31
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heifner heifner heifner approved these changes

@greg7mdp greg7mdp greg7mdp approved these changes

@systemzax systemzax Awaiting requested review from systemzax

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix how block_states are constructed for transition to contain correct validation tree data
4 participants
@linh2931 @ericpassmore @greg7mdp @heifner