Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how block_states are constructed for transition to contain correct validation tree data #31

Closed
arhag opened this issue Apr 15, 2024 · 0 comments · Fixed by #32
Closed
Assignees
Labels
bug The product is not working as was intended. 👍 lgtm

Comments

@arhag
Copy link
Member

arhag commented Apr 15, 2024

Transition creates block_states from transition blocks by computing the next block_state starting from the block_state of the IF Genesis block. The way this is currently done does not capture the Savanna action_mroots and so it constructs block_states that have a valid_t with incorrect data (specifically an empty digest for the action_mroot).

This code needs to be corrected to incorporate the correct action_mroots into the block_states constructed during the transition. We should disallow any constructor from being able to build a block_state with essential data missing.

@arhag arhag added this to the Savanna: Production-Ready milestone Apr 15, 2024
@arhag arhag added bug The product is not working as was intended. 👍 lgtm labels Apr 15, 2024
@arhag arhag changed the title Fix how block_states are constructed for transition to contan correct validation tree data Fix how block_states are constructed for transition to contain correct validation tree data Apr 15, 2024
@linh2931 linh2931 moved this from Todo to In Progress in Team Backlog Apr 15, 2024
@linh2931 linh2931 moved this from In Progress to Awaiting Review in Team Backlog Apr 15, 2024
@linh2931 linh2931 moved this from Awaiting Review to Done in Team Backlog Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The product is not working as was intended. 👍 lgtm
Projects
Archived in project
2 participants