Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump WordPress "tested up to" version 6.6 #195

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Conversation

jeffpaul
Copy link
Member

@jeffpaul jeffpaul commented Jul 5, 2024

Description of the Change

This PR bumps the WP tested-up-to 6.6, the minimum to 6.4, and updates the e2e tests to using 6.4 as the minimum as well.

Closes #194.

How to test the Change

Use Plugin ZIP action to get version from this PR and run through critical flows, otherwise review results of e2e tests.

Changelog Entry

Changed - Bump WordPress "tested up to" version 6.6.
Changed - Bump WordPress minimum supported version to 6.4.

Credits

Props @sudip-md, @jeffpaul.

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jeffpaul jeffpaul added this to the 1.4.0 milestone Jul 5, 2024
@jeffpaul jeffpaul self-assigned this Jul 5, 2024
@jeffpaul jeffpaul requested a review from dkotter as a code owner July 5, 2024 14:30
@github-actions github-actions bot added the needs:code-review This requires code review. label Jul 5, 2024
Copy link
Collaborator

@dkotter dkotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good here but E2E tests are failing. The error we're getting there is one we've seen across projects and requires us to use a newer version of wp-env. In updating that locally though, I get stuck in a dependency nightmare. This will need a closer look to get all that resolved

@github-actions github-actions bot added the needs:refresh This requires a refreshed PR to resolve. label Jul 8, 2024
@github-actions github-actions bot removed the needs:refresh This requires a refreshed PR to resolve. label Jul 9, 2024
@jeffpaul jeffpaul merged commit 64fec48 into develop Jul 9, 2024
11 checks passed
@jeffpaul jeffpaul deleted the bump/wp-version branch July 9, 2024 18:11
@faisal-alvi faisal-alvi modified the milestones: 1.4.0, 1.3.5 Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The plugin hasn't been tested with an upcoming version of WordPress
3 participants