Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port fixes from dev 2 0 #1633

Merged
merged 3 commits into from
Jan 25, 2025
Merged

Port fixes from dev 2 0 #1633

merged 3 commits into from
Jan 25, 2025
+3 −8

Conversation

zancas
Copy link
Member

@zancas zancas commented Jan 25, 2025 •
edited
Loading

I applied these suggested fixes to dev_2-0, this PR ports them to dev.

zancas added 3 commits January 24, 2025 19:35
@zancas
exclude 0 arg case
9ca3e0c 
(cherry picked from commit f05ce54)
@zancas
apply lint
b51c7f7 
(cherry picked from commit deebe07)
@zancas
include orchard_only_ua whenever possible.
c2cfd0b 
(cherry picked from commit fc3d230)
juanky201271
juanky201271 approved these changes Jan 25, 2025
View reviewed changes
Copy link
Contributor

@juanky201271 juanky201271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@juanky201271 juanky201271 merged commit c06fc7e into zingolabs:dev Jan 25, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanky201271 juanky201271 juanky201271 approved these changes

@Oscar-Pepper Oscar-Pepper Awaiting requested review from Oscar-Pepper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zancas @juanky201271