Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backported sub ua #1629

Merged
merged 7 commits into from
Jan 23, 2025
Merged

Backported sub ua #1629

merged 7 commits into from
Jan 23, 2025
+425 −314

Conversation

zancas
Copy link
Member

@zancas zancas commented Jan 22, 2025 •
edited
Loading

Also includes code to grab the first N VTs in the JSON String.

In CLT of both this feature and dev_2-0 206 tests passed.

@zancas zancas requested a review from Oscar-Pepper January 22, 2025 05:22
Oscar-Pepper
Oscar-Pepper approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@Oscar-Pepper Oscar-Pepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have approved with comments to consider before merging

zingolib/src/commands.rs Outdated Show resolved Hide resolved
zingolib/src/commands.rs Outdated Show resolved Hide resolved
@zancas zancas requested a review from Oscar-Pepper January 23, 2025 03:39
@zancas zancas merged commit b024eeb into zingolabs:dev_2-0 Jan 23, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oscar-Pepper Oscar-Pepper Awaiting requested review from Oscar-Pepper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zancas @Oscar-Pepper