-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reorg and improve continuity checks #1614
Open
Oscar-Pepper
wants to merge
41
commits into
zingolabs:dev_2-0
Choose a base branch
from
Oscar-Pepper:fix_reorg_and_improve_continuity_checks
base: dev_2-0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix reorg and improve continuity checks #1614
Oscar-Pepper
wants to merge
41
commits into
zingolabs:dev_2-0
from
Oscar-Pepper:fix_reorg_and_improve_continuity_checks
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmining shard range
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ontop of #1613
fix re-org bug where is was assumed the chain tip would be scanned but not always the case when sync is interrupted right at the beginning.
adds continuity checks to the end of a scan range to improve out of order sync safety and setup for the following fixed output batching PR
revisits wallet data cleanup after historic scans, now correctly uses highest_scanned_height