-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select Spendable Streamlined #1143
Select Spendable Streamlined #1143
Conversation
zingolib/src/wallet/transaction_records_by_id/trait_inputsource.rs
Outdated
Show resolved
Hide resolved
zingolib/src/wallet/transaction_records_by_id/trait_inputsource.rs
Outdated
Show resolved
Hide resolved
zingolib/src/wallet/transaction_records_by_id/trait_inputsource.rs
Outdated
Show resolved
Hide resolved
zingolib/src/wallet/transaction_records_by_id/trait_inputsource.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some notes.
d3b93a5
to
0a083a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left some comments which i think are worth implementing but non-blocking. The reason why I am requesting changes is because our expected fees seem to just be inputted by the test writer with no real reviewed expected fee calculator and some of the expected fees seem like they might be wrong to me. ALSO the new select_spendable_notes has lost control of selecting notes based on pool which i think is more important than value as it effects our pool policies and also is needed to reduce fees for user. although I havent worked out how this is even possible with the current LRZ code as the use_orchard / use_sapling booleans dont seem to work correctly or get fed into this function, so non-blocking... maybe we should implement this soon though.
zingolib/src/wallet/transaction_records_by_id/trait_inputsource.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonderful
This is a rewrite of select_spendable_notes, using what we have learned over the past couple of weeks.
Notable improvement is that the ignore_dust test goes from passing to failing for zip317