Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zip317 send all #1125

Merged
merged 26 commits into from
Jun 5, 2024
Merged

Zip317 send all #1125

merged 26 commits into from
Jun 5, 2024

Conversation

Oscar-Pepper
Copy link
Contributor

@Oscar-Pepper Oscar-Pepper commented May 23, 2024 •
edited
Loading

ontop of #1185

  • propose_send_all lightclient method for creating and storing a proposal for sending total confirmed shielded balance
  • added send all tests including fail cases
  • send all command
  • simple helpers for calculating total amount and fee from proposal with tests

a following PR with helperise spendable balance and add a spendable balance command to protect accidental "sending all funds when trying to find spendable balance" bugs

Oscar-Pepper added 22 commits May 23, 2024 14:55
@Oscar-Pepper
uncomment send_all code
114f888
@Oscar-Pepper
added proposal for total balance
c64929e
@Oscar-Pepper
added propose_send_all and test with no assertions
72287c7
@Oscar-Pepper
added helpers for calculating total fee and amounts for proposal
1d16dd2
@Oscar-Pepper
Merge branch 'add_transaction_request_mock_builder' into zip317_send_all
7aa4da3
@Oscar-Pepper
Merge branch 'add_transaction_request_mock_builder' into zip317_send_all
8c7dd67
@Oscar-Pepper
finished tests for helpers with payment pool error
50f8517
@Oscar-Pepper
Merge branch 'add_transaction_request_mock_builder' into zip317_send_all
ff4e35e
@Oscar-Pepper
added dbgs
916cc7d
@Oscar-Pepper
failing test when dust is in the wallet
ebed87a
@Oscar-Pepper
Merge branch 'dev' into zip317_send_all
0ecbe16
@Oscar-Pepper
discovered bug where fee not calculated correctly when dust is in wallet
3b1b196
@Oscar-Pepper
change incorrect names
b5e3f9c
@Oscar-Pepper
resolve conflicts with dev
ab9f4f3
@Oscar-Pepper
fix doc warnings
8f47c84
@Oscar-Pepper
resolve merge conflicts with
01f50b7
@Oscar-Pepper
fixes to select notes
a5de60e
@Oscar-Pepper
Merge branch 'dev' into zip317_send_all
05423c4
@Oscar-Pepper
add assertions to test and remove debugs
5f76abf
@Oscar-Pepper
fix clippy warnings
413c413
@Oscar-Pepper
revert changes to note selection
ea15e21
@Oscar-Pepper
Merge branch 'fix_note_selection_bugs' into zip317_send_all
fcd453e
@Oscar-Pepper Oscar-Pepper marked this pull request as ready for review June 4, 2024 15:15
@zancas zancas merged commit b0f459d into zingolabs:dev Jun 5, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zancas zancas zancas approved these changes

@AloeareV AloeareV Awaiting requested review from AloeareV

@idky137 idky137 Awaiting requested review from idky137

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Oscar-Pepper @zancas