Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRY mock implementation with declarative macro #1124

Merged
merged 2 commits into from
May 23, 2024
Merged

DRY mock implementation with declarative macro #1124

merged 2 commits into from
May 23, 2024

Conversation

zancas
Copy link
Member

@zancas zancas commented May 23, 2024

No description provided.

@zancas zancas requested a review from Oscar-Pepper May 23, 2024 16:46
fluidvanadium
fluidvanadium approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@fluidvanadium fluidvanadium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reduces lines of code!!

@fluidvanadium fluidvanadium merged commit 8d52640 into zingolabs:dev May 23, 2024
17 checks passed
@zancas zancas deleted the add_mock_builders_for_fee_calc_testing_2 branch May 30, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluidvanadium fluidvanadium fluidvanadium approved these changes

@Oscar-Pepper Oscar-Pepper Awaiting requested review from Oscar-Pepper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zancas @fluidvanadium