Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore manual tests #53

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Ignore manual tests #53

merged 3 commits into from
Jan 15, 2025

Conversation

zancas
Copy link
Member

@zancas zancas commented Jan 13, 2025

No description provided.

@zancas zancas requested review from ala-mode and nachog00 January 13, 2025 21:45
nachog00
nachog00 previously approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@nachog00 nachog00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems right to me.

I would add the intra doc links after merging #56

@zancas zancas dismissed nachog00’s stale review January 14, 2025 22:39

The merge-base changed after approval.

ala-mode
ala-mode approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@ala-mode ala-mode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, all tests pass. We will make a follow up issue to track the ignored tests.

tests/integration.rs Show resolved Hide resolved
tests/integration.rs Show resolved Hide resolved
@ala-mode ala-mode mentioned this pull request Jan 15, 2025
Open
@ala-mode
Copy link
Contributor

Made issue #57 to track ignored tests requiring a manual setup. Merging!

@ala-mode ala-mode merged commit 43ea596 into zingolabs:dev Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ala-mode ala-mode ala-mode approved these changes

@nachog00 nachog00 nachog00 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zancas @ala-mode @nachog00