Merge pull request #164 from AloeareV/tidying #362
ci.yml
on: push
Bitrot check
7m 55s
Clippy (MSRV)
6m 38s
Clippy (beta)
13s
Code coverage
4m 20s
Intra-doc links
8m 24s
Rustfmt
5s
Matrix: build-latest
Matrix: test
Annotations
13 errors and 8 warnings
Clippy (beta)
The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
|
Code coverage
Process completed with exit code 1.
|
useless use of `vec!`:
zaino-state/src/fetch.rs#L2627
error: useless use of `vec!`
--> zaino-state/src/fetch.rs:2627:32
|
2627 | let mut sorted_txids = vec![tx1_bytes, tx2_bytes];
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[tx1_bytes, tx2_bytes]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
= note: `-D clippy::useless-vec` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::useless_vec)]`
|
using `clone` on type `[u8; 32]` which implements the `Copy` trait:
zaino-state/src/fetch.rs#L2628
error: using `clone` on type `[u8; 32]` which implements the `Copy` trait
--> zaino-state/src/fetch.rs:2628:41
|
2628 | sorted_txids.sort_by_key(|hash| hash.clone());
| ^^^^^^^^^^^^ help: try dereferencing it: `*hash`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
using `clone` on type `[u8; 32]` which implements the `Copy` trait:
zaino-state/src/fetch.rs#L2624
error: using `clone` on type `[u8; 32]` which implements the `Copy` trait
--> zaino-state/src/fetch.rs:2624:29
|
2624 | let mut tx2_bytes = tx_2.first().as_ref().clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*tx_2.first().as_ref()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
using `clone` on type `[u8; 32]` which implements the `Copy` trait:
zaino-state/src/fetch.rs#L2622
error: using `clone` on type `[u8; 32]` which implements the `Copy` trait
--> zaino-state/src/fetch.rs:2622:29
|
2622 | let mut tx1_bytes = tx_1.first().as_ref().clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*tx_1.first().as_ref()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
`assert_eq` of unit values detected. This will always succeed:
zaino-state/src/fetch.rs#L2051
error: `assert_eq` of unit values detected. This will always succeed
--> zaino-state/src/fetch.rs:2051:9
|
2051 | assert_eq!(json_service_mempool.sort(), fetch_service_mempool.sort());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_cmp
= note: `#[deny(clippy::unit_cmp)]` on by default
|
using `clone` on type `AddressBalance` which implements the `Copy` trait:
zaino-state/src/fetch.rs#L1951
error: using `clone` on type `AddressBalance` which implements the `Copy` trait
--> zaino-state/src/fetch.rs:1951:14
|
1951 | dbg!(fetch_service_balance.clone());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `fetch_service_balance`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `-D clippy::clone-on-copy` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::clone_on_copy)]`
|
Clippy (MSRV)
Clippy had exited with the 101 exit code
|
Test on ubuntu-latest
Process completed with exit code 101.
|
Test on macOS-latest
The job was canceled because "ubuntu-latest" failed.
|
Test on windows-latest
The job was canceled because "ubuntu-latest" failed.
|
Test on windows-latest
The operation was canceled.
|
Rustfmt
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Clippy (beta)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Code coverage
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Clippy (MSRV)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Bitrot check
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Latest build on ubuntu-latest
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Intra-doc links
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Test on ubuntu-latest
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|