[FEATURE] Add support for the dvh, lvh and svh length units (My…

…Intervals#627) Fixes MyIntervals#412 For now, the `TestCase` just tests that all the unit values are parsed. (Other tests can be added here, but are beyond the scope of this change.) Co-authored-by: Kai König <[email protected]> Co-authored-by: Jake Hotson <[email protected]>
ziegenberg · Jun 29, 2024 · ab0baf7 · ab0baf7
1 parent 2487bde
commit ab0baf7
Show file tree

Hide file tree

Showing 3 changed files with 59 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,8 @@ This project adheres to [Semantic Versioning](https://semver.org/).
 ### Added
 - Add support for inserting an item in a CSS list (#545)
 
+- Add support for the `dvh`, `lvh` and `svh` length units (#415)
+
 ### Changed
 
 ### Deprecated

diff --git a/src/Value/Size.php b/src/Value/Size.php
@@ -19,7 +19,12 @@ class Size extends PrimitiveValue
      *
      * @internal
      */
-    const ABSOLUTE_SIZE_UNITS = ['px', 'cm', 'mm', 'mozmm', 'in', 'pt', 'pc', 'vh', 'vw', 'vmin', 'vmax', 'rem'];
+    const ABSOLUTE_SIZE_UNITS = [
+        'px', 'pt', 'pc',
+        'cm', 'mm', 'mozmm', 'in',
+        'vh', 'dvh', 'svh', 'lvh',
+        'vw', 'vmin', 'vmax', 'rem',
+    ];
 
     /**
      * @var array<int, string>

diff --git a/tests/Value/SizeTest.php b/tests/Value/SizeTest.php
@@ -0,0 +1,51 @@
+<?php
+
+namespace Sabberworm\CSS\Tests\Value;
+
+use PHPUnit\Framework\TestCase;
+use Sabberworm\CSS\Parsing\ParserState;
+use Sabberworm\CSS\Settings;
+use Sabberworm\CSS\Value\Size;
+
+/**
+ * @covers \Sabberworm\CSS\Value\Size
+ */
+final class SizeTest extends TestCase
+{
+    /**
+     * @return array<string, array{0: string}>
+     */
+    public static function provideUnit()
+    {
+        $units = [
+            'px', 'pt', 'pc',
+            'cm', 'mm', 'mozmm', 'in',
+            'vh', 'dvh', 'svh', 'lvh',
+            'vw', 'vmin', 'vmax', 'rem',
+            '%', 'em', 'ex', 'ch', 'fr',
+            'deg', 'grad', 'rad', 's', 'ms', 'turn', 'Hz', 'kHz',
+        ];
+
+        return \array_combine(
+            $units,
+            \array_map(
+                function ($unit) {
+                    return [$unit];
+                },
+                $units
+            )
+        );
+    }
+
+    /**
+     * @test
+     *
+     * @dataProvider provideUnit
+     */
+    public function parsesUnit($unit)
+    {
+        $subject = Size::parse(new ParserState('1' . $unit, Settings::create()));
+
+        self::assertSame($unit, $subject->getUnit());
+    }
+}