Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MicroBlaze Port #53576

Closed
wants to merge 36 commits into from
Closed

MicroBlaze Port #53576

wants to merge 36 commits into from

Conversation

alpsayin
Copy link
Contributor

@alpsayin alpsayin commented Jan 7, 2023 •
edited
Loading

I apologise that I don't know what kind of information I should be presenting here.
So please let me know and I'll do whatever you need!

Steps to test or reproduce

compiler: mb-gcc from topic-microblaze branch of sdk-ng at
https://github.com/zephyrproject-rtos/sdk-ng/tree/topic-microblaze
zephyrproject-rtos/sdk-ng#647

Dependencies to resolve known test failures

  1. First and foremost, I'll need some help making this PR build with topic-microblaze
  2. mbedTLS: Fix little-endian Microblaze does not work when MBEDTLS_HAVE_ASM is defined mbedtls#38
  3. Zephyr: Fix Zbus Benchmark Sample is smashing the stack and is too fast #53563
  4. SDK-NG: MicroBlaze Toolchain sdk-ng#621
    1. Depends on binutils-gdb: microblaze: Invalid data offsets (pointer) after relaxation. binutils-gdb#7
  5. Other SDK-NG gcc/bintuils/gdb fixes: microblaze: pull in gcc/bintuils/gdb patches from meta-xilinx sdk-ng#647
    3. Picolibc support picolibc: Pull in Microblaze support sdk-ng#641
    4. microblaze: apply gcc patches from meta-xilinx repository gcc#24
    5. microblaze: apply binutils patches from meta-xilinx repository binutils-gdb#10
    6. microblaze: apply gdb patches from meta-xilinx repository binutils-gdb#11
    7. microblaze: Fix -Os right shift optimization is allowed into delay slot gcc#37

@alpsayin alpsayin changed the title Microblaze Port MicroBlaze Port Jan 7, 2023
@alpsayin alpsayin mentioned this pull request Jan 18, 2023
Merged
@alpsayin alpsayin force-pushed the microblaze_public branch 4 times, most recently from 6f89a31 to 713b955 Compare February 20, 2023 23:16
@alpsayin alpsayin force-pushed the microblaze_public branch 3 times, most recently from 0495ed2 to 1cdf4cb Compare April 21, 2023 11:26
@github-actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Jun 21, 2023
@alpsayin alpsayin force-pushed the microblaze_public branch from 1cdf4cb to af41347 Compare June 23, 2023 11:31
@alpsayin
Copy link
Contributor Author

alpsayin commented Jun 23, 2023 •
edited
Loading

Still going on, rather slowly...
I've come across some issues while applying GDB patches to sdk-ng (https://github.com/zephyrproject-rtos/sdk-ng/actions/runs/5163487701/jobs/9301839276?pr=647).
Otherwise, gcc and binutils patches applied successfully (zephyrproject-rtos/sdk-ng#647 )
picolibc is also in a happy situation but I perceive it blocked on sdk-ng because picolibc CI would need at least the zephyr sdk-ng to have a correct toolchain.

p.s. the comment is mostly because I got a Stale label; thought best to give a bit of an update to advertise I haven't just left off.

@github-actions github-actions bot removed the Stale label Jun 24, 2023
@alpsayin alpsayin force-pushed the microblaze_public branch 4 times, most recently from afcd3d7 to 15c24c4 Compare July 2, 2023 20:55
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Sep 1, 2023
@alpsayin
Copy link
Contributor Author

alpsayin commented Sep 1, 2023

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

Go away github...

Anyways, I've finally managed to apply gdb patches that result in a build. But it turned out that gcc patches introduced an effin' broken microblaze64 toolchain which disrupted picolibc build. I've -literally- just found out how to disable m64 multilib from picolibc and proceeding with picolibc tests. Once that's done, will squash the patches and sdk-ng PR will be ready for reviews. Then I can start cleaning up picolibc patch getting it ready for PR. If I can have picolibc and sdk-ng ready in before 0.17, this patch can probably start building with sdk-0.17.

@github-actions github-actions bot removed the Stale label Sep 2, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Dec 1, 2023
@alpsayin
Copy link
Contributor Author

alpsayin commented Dec 1, 2023

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

Go away github...

@github-actions github-actions bot removed the Stale label Dec 2, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

alpsayin added 25 commits October 18, 2024 18:41
@alpsayin
arch: microblaze: Weak sys_arch_reboot implementation
50ff4d1 
Internal references: FWRIVERHD-4554

Signed-off-by: Alp Sayin <[email protected]>
@alpsayin
arch: microblaze: Toolchain: introduce MicroBlaze to build system
98ff2af 
Internal references: FWRIVERHD-4980,FWRIVERHD-4991

Signed-off-by: Alp Sayin <[email protected]>
@alpsayin
arch: microblaze: Linker: add linker script and define output format
f774ec3 
Internal references: FWRIVERHD-4980,FWRIVERHD-4989

Signed-off-by: Alp Sayin <[email protected]>
@alpsayin
arch: microblaze: add MicroBlaze arch headers
e59b38a 
Internal references: FWRIVERHD-4554

Signed-off-by: Alp Sayin <[email protected]>
@alpsayin
include: arch: add MicroBlaze to cpu.h and arch_inlines.h
a6a567c 
Internal references: FWRIVERHD-4554

Signed-off-by: Alp Sayin <[email protected]>
@alpsayin
debug: thread_info: point MicroBlaze stack pointer to r1
d1cbfde 
Internal references: FWRIVERHD-4554

Signed-off-by: Alp Sayin <[email protected]>
@alpsayin
arch: microblaze: add MicroBlaze to arch/KConfig
3e4b3f4 
Internal references: FWRIVERHD-4554

Signed-off-by: Alp Sayin <[email protected]>
@alpsayin
arch: microblaze: add CMake files for building arch
0359d19 
Internal references: FWRIVERHD-4554

Signed-off-by: Alp Sayin <[email protected]>
@alpsayin
dts: bindings: cpu: add MicroBlaze cpu binding
2f44610 
Internal references: FWRIVERHD-4554, FWRIVERHD-5063

Signed-off-by: Alp Sayin <[email protected]>
@alpsayin
soc: microblaze: add demo SoC with timer, interrupt_controller and uart
e7b8154 
Internal references: FWRIVERHD-5063

Signed-off-by: Alp Sayin <[email protected]>
@alpsayin
boards: microblaze: add QEMU demo board with qemu hw-dtb
853d4f6 
Internal references: FWRIVERHD-5063

Signed-off-by: Alp Sayin <[email protected]>
@alpsayin
script: logging/dictionary: add arch MicroBlaze
019cc7a 
Internal references: FWRIVERHD-5201

Signed-off-by: Alp Sayin <[email protected]>
@alpsayin
tests: kernel: interrupt: MicroBlaze trigger_irq implementation (emul…
4f4e122 
…ated)

Internal references: FWRIVERHD-4554

Signed-off-by: Alp Sayin <[email protected]>
@alpsayin
tests: microblaze: test specific configuration additions for MicroBlaze
5bf240b 
Internal references: FWRIVERHD-5201

Signed-off-by: Alp Sayin <[email protected]>
@alpsayin
zephyr-3.7 migration: deprecate z_arch_esf_t
522c5aa 
Follows 3998e18
zephyrproject-rtos#73593

Signed-off-by: Alp Sayin <[email protected]>
@alpsayin
zephyr-3.7 migration: include microblaze_asm.h only in asm files
0de8037 
Otherwise, utterly generic macros I defined clash with other people's
utterly generic macros.

Signed-off-by: Alp Sayin <[email protected]>
@alpsayin
migrate linker: CONFIG_COMMON_LIBC_MALLOC_ARENA_SIZE can be -1 now
191d43a 
And other things

Signed-off-by: Alp Sayin <[email protected]>
@alpsayin
migrate irq_offload: fix arch_irq_offload_init undefined reference
1447c5f 
Follows 7e225ef

Signed-off-by: Alp Sayin <[email protected]>
@alpsayin
fix: secure_storage tests doesn't filter out any archs...
417f564 
Signed-off-by: Alp Sayin <[email protected]>
@alpsayin
fix: tickfull/tickless systimer inits are swapped
85a1cba 
Signed-off-by: Alp Sayin <[email protected]>
@alpsayin
fix: -Wrestrict error because gcc thinks (FILE*(1)) and 1 are the…
c21d6c2 
… same arguments

Signed-off-by: Alp Sayin <[email protected]>
@alpsayin
debug: start investigating missing sbrk
a9a9df3 
Signed-off-by: Alp Sayin <[email protected]>
@alpsayin
Revert "debug: start investigating missing sbrk"
4f0f6c9 
This reverts commit 39feff5cd566ea6b874f2064fa1d663546c07934.

Signed-off-by: Alp Sayin <[email protected]>
@alpsayin
bodge: sbrk impl stolen from newlib to get minimal libc working w/ …
9dab8d0 
…microblaze

Signed-off-by: Alp Sayin <[email protected]>
@alpsayin
WIP: Builds and tests pass: fixes/patches to be squashed
2cc7aa2 
2213 test scenarios (2008 test instances) selected, 1599 configurations skipped (1399 by static filter, 200 at runtime).
409 of 2008 test configurations passed (100.00%), 0 failed, 0 errored, 1599 skipped with 0 warnings in 590.92 seconds
In total 4651 test cases were executed, 11325 skipped on 1 out of total 1 platforms (100.00%)
376 test configurations executed on platforms, 33 test configurations were only built.

Signed-off-by: Alp Sayin <[email protected]>
@github-actions GitHub Actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Dec 18, 2024
@github-actions github-actions bot closed this Jan 1, 2025
@alpsayin
Copy link
Contributor Author

alpsayin commented Jan 2, 2025 •
edited
Loading

I will re-open this (i.e. send a new pull request) at a later time after sdk-ng fixes are in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alpsayin @stephanosio @kartben