PoC Ledger Support #67
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacu
force-pushed
the
feature/ledger
branch
2 times, most recently
from
bc0df90 to
278ae5a
Compare
Add `ledger-zcash` dependency and `ledger-support` feature Add Toolchain file WIP - init with ledger command Fix cargo files WIP - Use diversifier key capable custom version of ledger software Create UFVK from Ledger device and sync it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test of how a Ledger Integration would look like in zec-sqlite-cli
Ledger currently doesn't support UA and UFVKs but pulling the pieces things can at least compile.
There's work to support UAs Zondax/ledger-zcash#128 but it will require going through
an app release cycle with Ledger so it's better to first interate this way and try PCZT + Ledger here.