Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import-ufvk command #32

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Add import-ufvk command #32

merged 3 commits into from
Jul 31, 2024

Conversation

str4d
Copy link
Collaborator

@str4d str4d commented Jul 31, 2024

No description provided.

str4d added 2 commits July 31, 2024 22:38
In particular, this enables creating a zero-account wallet for testing
view-only functionality.
Copy link
Collaborator

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 8937ab3 with the caveat that it would be helpful to also add UFVK export to make this really useful. IIRC we never updated zcashd to provide UFVK export? Or did we?

src/commands/list_tx.rs Show resolved Hide resolved
This was breaking on view-only wallets created with `--accounts 0`, that
had no accounts with a ZIP 32 index of 0.
@str4d
Copy link
Collaborator Author

str4d commented Jul 31, 2024

Force-pushed to address comment.

Copy link
Collaborator

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 1bb3b12 modulo request for UFVK/UIVK export functionality.

@str4d
Copy link
Collaborator Author

str4d commented Jul 31, 2024

Opened #33 for your additional request.

@str4d str4d merged commit 993a8bd into main Jul 31, 2024
17 checks passed
@str4d str4d deleted the import-ufvk branch July 31, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants