Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use vite #171

Merged
merged 5 commits into from
Apr 17, 2024
Merged

build: use vite #171

merged 5 commits into from
Apr 17, 2024

Conversation

tpluscode
Copy link
Collaborator

Excuse the yarn -> npm switch

This should resolve most of the dependabot issues and result in nicer builds

@tpluscode tpluscode requested a review from ludovicm67 April 16, 2024 20:17
Copy link

changeset-bot bot commented Apr 16, 2024

⚠️ No Changeset found

Latest commit: f655b4a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.30%. Comparing base (a9a3a1a) to head (ab88aaf).

❗ Current head ab88aaf differs from pull request most recent head f655b4a. Consider uploading reports for the commit f655b4a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
+ Coverage   97.17%   97.30%   +0.12%     
==========================================
  Files          22       22              
  Lines        1558     1558              
==========================================
+ Hits         1514     1516       +2     
+ Misses         44       42       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ludovicm67
Copy link
Member

Looks good! Can we also try to use Node 20?

@tpluscode tpluscode merged commit ec928b5 into master Apr 17, 2024
6 checks passed
@tpluscode tpluscode deleted the vite branch April 17, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants