Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dev inspect definition #3413

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

AustinAbro321
Copy link
Contributor

Description

Adds a zarf dev inspect definition command which shows the package definition after templating, flavors, and component imports are applied.

First part of implementing ZEP 0008-rework-inspect

Checklist before merging

Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321 AustinAbro321 requested review from a team as code owners January 17, 2025 21:06
Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit 9e9777b
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/678ac9bc89ea930008bc4a43
😎 Deploy Preview https://deploy-preview-3413--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Austin Abro <[email protected]>
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 5.12821% with 37 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/cmd/dev.go 0.00% 36 Missing ⚠️
src/internal/packager2/layout/create.go 66.66% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/internal/packager2/layout/create.go 24.84% <66.66%> (ø)
src/cmd/dev.go 0.00% <0.00%> (ø)

Signed-off-by: Austin Abro <[email protected]>
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit, feel free to merge when you get that fixed

@@ -20,6 +20,18 @@ import (
func TestUseCLI(t *testing.T) {
t.Log("E2E: Use CLI")

// TODO once cmd is refactored to accept an io.Writer, move this test to DevInspectDefinitionOptions.Run()
t.Run("zarf package inspect definition", func(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: zarf dev inspect definition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants