-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dev inspect definition #3413
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
✅ Deploy Preview for zarf-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Austin Abro <[email protected]>
Codecov ReportAttention: Patch coverage is
|
Signed-off-by: Austin Abro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nit, feel free to merge when you get that fixed
@@ -20,6 +20,18 @@ import ( | |||
func TestUseCLI(t *testing.T) { | |||
t.Log("E2E: Use CLI") | |||
|
|||
// TODO once cmd is refactored to accept an io.Writer, move this test to DevInspectDefinitionOptions.Run() | |||
t.Run("zarf package inspect definition", func(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: zarf dev inspect definition
Description
Adds a
zarf dev inspect definition
command which shows the package definition after templating, flavors, and component imports are applied.First part of implementing ZEP 0008-rework-inspect
Checklist before merging