Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 1 CPU maxed out during zarf connect git #2111

Merged
merged 1 commit into from
Oct 31, 2023
Merged

fix: 1 CPU maxed out during zarf connect git #2111

merged 1 commit into from
Oct 31, 2023

Conversation

bdw617
Copy link
Contributor

@bdw617 bdw617 commented Oct 30, 2023

Description

removed the loop that kept calling runtime.Gosched(), it was trying to be nice, and yet using all the CPU time (1 thread) @jeff-mccoy please verify,

Fixes #1357

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented Oct 30, 2023

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 0a86ef6
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/65403ed6378c520008494beb

Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

lgtm, fixes CPU spikes in system profiler (left before, right after (not above noise))

@Racer159 Racer159 merged commit 6a6be54 into main Oct 31, 2023
23 checks passed
@Racer159 Racer159 deleted the fix-1357 branch October 31, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running zarf connect git uses 100% CPU
2 participants