Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: helm charts have the potential to clobber each other and don't match repo names #2066

Closed
wants to merge 22 commits into from
Closed

fix: helm charts have the potential to clobber each other and don't match repo names #2066

wants to merge 22 commits into from

Conversation

Racer159
Copy link
Contributor

@Racer159 Racer159 commented Oct 12, 2023 •
edited
Loading

Description

This adds support for local charts from tarballs instead of only directories.

Related Issue

Fixes #2062
Fixes #1765

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented Oct 12, 2023 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit f0b9857
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/653c22c516609d00083b0926

@Racer159 Racer159 marked this pull request as draft October 12, 2023 01:07
@Racer159 Racer159 requested a review from Noxsios October 13, 2023 21:55
@Racer159 Racer159 marked this pull request as ready for review October 13, 2023 21:55
@Racer159 Racer159 requested review from Madeline-UX, lucasrod16 and a team as code owners October 13, 2023 21:55
Noxsios
Noxsios previously approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@Noxsios Noxsios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Racer159 Racer159 marked this pull request as draft October 14, 2023 00:16
@Racer159
Copy link
Contributor Author

Moving back to a draft to work more on addressing #1765 - this would require indexing charts like files and data injections.

@Racer159
Copy link
Contributor Author

Breaking changes:

  1. Chart names must match between chart.name and the name in the Chart.yaml
  2. Charts are now held inside of an indexed folder instead of the root of the component

@Racer159 Racer159 added this to the (2023.11.21) milestone Nov 2, 2023
@Racer159 Racer159 modified the milestones: (2023.11.21), (2023.12.05) Nov 16, 2023
Racer159 added a commit that referenced this pull request Nov 28, 2023
@Racer159
chore: refactor helm and pull in non-breaking changes from #2066
1dd0335
@Racer159 Racer159 added the needs-tests PR Label - Tests required to merge label Nov 29, 2023
@Racer159 Racer159 changed the title feat: add support for local helm chart tarballs fix: helm charts have the potential to clobber each other and don't match repo names Nov 29, 2023
@Racer159
Copy link
Contributor Author

Racer159 commented Dec 3, 2023

Superseded by #2174

@Racer159 Racer159 closed this Dec 3, 2023
@Noxsios Noxsios deleted the 2063-local-path-tarball-and-fixes branch March 21, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noxsios Noxsios Noxsios left review comments

@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy

@mike-winberry mike-winberry Awaiting requested review from mike-winberry

@Madeline-UX Madeline-UX Awaiting requested review from Madeline-UX

@lucasrod16 lucasrod16 Awaiting requested review from lucasrod16

Assignees
No one assigned
Labels
needs-tests PR Label - Tests required to merge
Projects
None yet
Milestone
(2023.12.05)
2 participants
@Racer159 @Noxsios