Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade versions of reviewdog and sqlfluff #136

Merged
merged 6 commits into from
Dec 2, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
fail-fast: false
matrix:
sqlfluff:
- "3.0.7"
- "3.2.5"
extra_requirements_txt:
- "testdata/test_failed_dbt/extra_requirements-1.6.txt"
- "testdata/test_failed_dbt/extra_requirements-1.7.txt"
Expand Down Expand Up @@ -57,7 +57,7 @@ jobs:
fail-fast: false
matrix:
sqlfluff:
- "3.0.7"
- "3.2.5"
extra_requirements_txt:
- "testdata/test_failed_dbt/extra_requirements-1.6.txt"
- "testdata/test_failed_dbt/extra_requirements-1.7.txt"
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
FROM python:3.13-slim

ENV REVIEWDOG_VERSION="v0.17.4"
ENV REVIEWDOG_VERSION="v0.20.2"

ENV WORKING_DIRECTORY="/workdir"
WORKDIR "$WORKING_DIRECTORY"
Expand All @@ -22,7 +22,7 @@ RUN apt-get update -y \
RUN wget -O - -q https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh| sh -s -- -b /usr/local/bin/ ${REVIEWDOG_VERSION}

# Install pip
RUN pip install --no-cache-dir --upgrade pip==23.1.2
RUN pip install --no-cache-dir --upgrade pip==24.3.0

# Set the entrypoint
COPY . "$WORKING_DIRECTORY"
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
with:
github_token: ${{ secrets.github_token }}
reporter: github-pr-review
sqlfluff_version: "3.0.7"
sqlfluff_version: "3.2.5"
sqlfluff_command: "fix" # Or "lint"
config: "${{ github.workspace }}/.sqlfluff"
paths: "${{ github.workspace }}/models"
Expand Down Expand Up @@ -93,13 +93,13 @@ inputs:
reviewdog_version:
description: "reviewdog version"
required: false
default: "v0.17.4"
default: "v0.20.2"
### Flags for sqlfluff ###
sqlfluff_version:
description: |
sqlfluff version. Use the latest version if not set.
required: false
default: "3.0.7"
default: "3.2.5"
sqlfluff_command:
description: "The sub command of sqlfluff. One of lint and fix"
required: false
Expand Down
4 changes: 2 additions & 2 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,13 @@ inputs:
reviewdog_version:
description: "reviewdog version"
required: false
default: "v0.17.4"
default: "v0.20.2"
### Flags for sqlfluff ###
sqlfluff_version:
description: |
sqlfluff version. Use the latest version if not set.
required: false
default: "3.0.7"
default: "3.2.5"
sqlfluff_command:
description: "The sub command of sqlfluff. One of lint and fix"
required: false
Expand Down
4 changes: 2 additions & 2 deletions testdata/test_failed_dbt/models/staging/staging_test02.sql
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [sqlfluff] <LT02> reported by reviewdog 🐶
Expected indent of 4 spaces.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [sqlfluff] <LT02> reported by reviewdog 🐶
Expected indent of 4 spaces.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [sqlfluff] <LT02> reported by reviewdog 🐶
Expected indent of 4 spaces.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [sqlfluff] <LT02> reported by reviewdog 🐶
Expected indent of 4 spaces.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [sqlfluff] <LT02> reported by reviewdog 🐶
Expected indent of 4 spaces.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [sqlfluff] <LT02> reported by reviewdog 🐶
Expected indent of 4 spaces.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [sqlfluff] <LT02> reported by reviewdog 🐶
Expected indent of 4 spaces.

Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@

SELECT
1 AS x,
2 AS y,
3 AS z
2 AS y,
3 AS z
Comment on lines 5 to +7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[sqlfluff-fix] reported by reviewdog 🐶

Suggested change
1 AS x,
2 AS y,
3 AS z
2 AS y,
3 AS z
1 AS x,
2 AS y,
3 AS z

Comment on lines 5 to +7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[sqlfluff-fix] reported by reviewdog 🐶

Suggested change
1 AS x,
2 AS y,
3 AS z
2 AS y,
3 AS z
1 AS x,
2 AS y,
3 AS z