Implement array trait, drop traittypes dependency #161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
traittypes is unmaintaned (last code modification 4 years ago) and is the source of a pytest warning we've been getting for a while:
This is a minimal replacement for
traittypes.Array
that I think covers what we need. The main thing I did not add is any explicit dtype handling -- I could, but yt_idv isn't using any at the moment so I didn't add it (but don't think it'd be hard)... I also could refactorYTPositionTrait
to inherit from the newArrayTrait
, but thought it'd be better to make that as a subsequent change.