Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chip 구현 #25

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Chip 구현 #25

wants to merge 3 commits into from

Conversation

hoyaboi
Copy link

@hoyaboi hoyaboi commented Dec 30, 2024

Summary

Chip을 구현하였습니다.

  • 선택 여부에 따른 칩 상태 변경 구현
  • 비활성화 여부 설정
  • 텍스트 좌, 우측 아이콘 이미지 삽입

Describe your changes

Chip

@cometj03 cometj03 requested a review from a team December 31, 2024 02:48
@cometj03
Copy link
Member

@yourssu/android-maintainer 이걸로 리뷰어 요청하시면 됩니다!

cometj03
cometj03 reviewed Dec 31, 2024
View reviewed changes
Copy link
Member

@cometj03 cometj03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깔끔하네요! 첫 PR 수고하셨습니다 👍

compose/src/main/kotlin/com/yourssu/handy/compose/Chip.kt Outdated Show resolved Hide resolved
HI-JIN2
HI-JIN2 approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@HI-JIN2 HI-JIN2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

호야님 수고많으셨습니다~!! 새해에도 같이 화이팅 해봐요🔥

compose/src/main/kotlin/com/yourssu/handy/compose/Chip.kt Outdated Show resolved Hide resolved
kangyuri1114
kangyuri1114 reviewed Dec 31, 2024
View reviewed changes
Copy link
Member

@kangyuri1114 kangyuri1114 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

첫 PR 수고하셨습니다!!

compose/src/main/kotlin/com/yourssu/handy/compose/Chip.kt Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kangyuri1114 kangyuri1114 kangyuri1114 left review comments

@cometj03 cometj03 cometj03 left review comments

@HI-JIN2 HI-JIN2 HI-JIN2 approved these changes

Assignees

@hoyaboi hoyaboi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hoyaboi @cometj03 @kangyuri1114 @HI-JIN2