Scaffold 구현 #15
Open
Scaffold 구현 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cometj03
reviewed
Jan 12, 2025
| fab: @Composable () -> Unit, | ||
| bottomBar: @Composable () -> Unit | ||
| ) { | ||
| val snackBarPxValue = LocalDensity.current.run { SnackBarBottomSpacing.toPx() }.toInt() |
There was a problem hiding this comment.
with(LocalDensity.current) { ... }
보통 이렇게 하는 게 일반적인데 취향차이인 것 같긴 해요
|
|
||
| val looseConstraints = constraints.copy(minWidth = 0, minHeight = 0) | ||
|
|
||
| val topBarPlaceable = subcompose(ScaffoldLayoutContent.TopBar) { |
There was a problem hiding this comment.
subcompose 괄호 안에 넣어주는 게 무엇을 의미하는건가요?
| traversalIndex = 2f | ||
| } | ||
| ) { | ||
| content(PaddingValues(0.dp)) |
Comment on lines
+109
to
+112
| val snackBarPlaceable = subcompose(ScaffoldLayoutContent.Snackbar) { | ||
| Box(modifier = Modifier | ||
| .padding(horizontal = SnackBarHorizontalSpacing) // TODO : SnackBar 컴포넌트 자체에서 margin을 줄지 여기서 주어야 할지? | ||
| .semantics { |
There was a problem hiding this comment.
흠.. 머테리얼 SnackBar를 사용해보았을땐 기본으로 화면 너비를 채우고 밖에서 마진을 넣어주게 되어있긴 하네요
지금은 제가 SnackBar 컴포넌트 자체에 마진을 주긴했는데 이 파일에서 넣어주는 걸로 할까요?
There was a problem hiding this comment.
아하 그러면 snackbar에 이미 되어있다면 여기서 마진 없도록 하겠습니다~!
Comment on lines
+139
to
+142
| val bottomBarVerticalOffset = layoutHeight - bottomBarPlaceable.height | ||
| val fabVerticalOffset = | ||
| bottomBarVerticalOffset - fabPlaceable.height - fabBottomMarginPxValue | ||
| val snackBarVerticalOffset = fabVerticalOffset - snackBarPlaceable.height - snackBarPxValue |
There was a problem hiding this comment.
fab이 없을 땐 fabVerticalOffset이 bottomBarVerticalOffset과 같아야 할 것 같아요.
쉽게 설명하자면 지금 상황에서 fab이 없을 때 snackBar가 어디에 배치될지 생각해보심 됩니다. 아마 생각보다 높은 곳에 배치될거예요. (fab 마진 + snackBar 마진 만큼)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
Scaffold 구현
Preview 사진
아직 component들이 구현 중이라 색상으로 대체했습니다.
구성요소
옵션 설명
그려지는 순서
semantic의 traversalIndex값이 작은 순서대로
topBar -> bottomBar -> content -> FAB -> snackBar
*padding값
화면에서의 padding values -> object로 관리
snackBar : horizontal 16.dp, bottom 16.dp
FAB : end 16.dp, bottom 32.dp
(SnackBar가 FAB보다 상단에 있어야 함)