-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new wallpaper viewer design #178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing: I'd prefer to keep the floating action bar instead of placing the buttons at the bottom with a transparent background, I feel like the current floating action bar with buttons make it look more Material Design 3.
Though I'm fine with the color palette placement changes, they no longer need to be part of that action bar (as in your changes).
Awesome apart from that 👍
(From Matrix)
Floating Action Bar will look good. but we'll have to remove the blur effects to make it look less odd. |
Should I leave the top bar transparent? |
app/src/main/java/com/bnyro/wallpaper/ui/components/WallpaperView.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/bnyro/wallpaper/ui/components/WallpaperView.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/bnyro/wallpaper/ui/models/WallpaperHelperModel.kt
Outdated
Show resolved
Hide resolved
One second, I'll quickly build and test what looks better. |
I've tested both, I think it's better to keep it as it is now (top bar being not transparent) |
Only one small UI nitpick left from my side, then I'm fully happy with this PR :) The bottom sheet to edit the wallpaper currently has two filled buttons: "Reset" and "Apply". My suggestion would be to place
Apart from that I think that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for your hard work on that!
Thank you, I will probably create a follow up PR adding navigation support. Using dialogs for everything is not a good idea IMO. |
New Features
Please let me know if you have any suggestions