Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new wallpaper viewer design #178

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

SuhasDissa
Copy link
Member

New Features

  • Redesigned wallpaper view screen
  • Redesigned wallpaper info dialog
  • Show wallpapers in pager view (with horizontal scroll)
  • More responsive filter editor
  • Option to crop and apply wallpaper through the system gallery app (or any other app that supports it)

Please let me know if you have any suggestions

@SuhasDissa SuhasDissa requested review from M00NJ and Bnyro February 10, 2024 17:22
Copy link
Member

@Bnyro Bnyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing: I'd prefer to keep the floating action bar instead of placing the buttons at the bottom with a transparent background, I feel like the current floating action bar with buttons make it look more Material Design 3.
Though I'm fine with the color palette placement changes, they no longer need to be part of that action bar (as in your changes).
Awesome apart from that 👍

(From Matrix)

@SuhasDissa
Copy link
Member Author

One thing: I'd prefer to keep the floating action bar instead of placing the buttons at the bottom with a transparent background, I feel like the current floating action bar with buttons make it look more Material Design 3.

Floating Action Bar will look good. but we'll have to remove the blur effects to make it look less odd.

@SuhasDissa
Copy link
Member Author

@SuhasDissa
Copy link
Member Author

Should I leave the top bar transparent?

@Bnyro
Copy link
Member

Bnyro commented Feb 13, 2024

Should I leave the top bar transparent?

One second, I'll quickly build and test what looks better.

@Bnyro
Copy link
Member

Bnyro commented Feb 13, 2024

Should I leave the top bar transparent?

I've tested both, I think it's better to keep it as it is now (top bar being not transparent)

@Bnyro
Copy link
Member

Bnyro commented Feb 13, 2024

Only one small UI nitpick left from my side, then I'm fully happy with this PR :)

The bottom sheet to edit the wallpaper currently has two filled buttons: "Reset" and "Apply".

My suggestion would be to place

  1. the "Reset" button at the very left
  2. the "Apply" button to the very right
  3. a "Dismiss" button to the left of the "Apply" button

Apart from that I think that TextButton's would look a bit nicer here than normal Button's because they look less clunky.

Copy link
Member

@Bnyro Bnyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for your hard work on that!

@SuhasDissa
Copy link
Member Author

Awesome, thanks for your hard work on that!

Thank you, I will probably create a follow up PR adding navigation support. Using dialogs for everything is not a good idea IMO.

@SuhasDissa SuhasDissa merged commit ce9db60 into you-apps:main Feb 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants