feat: option to set wallpaper changer network type (closes #183)

you-apps · Apr 2, 2024 · cdf3509 · cdf3509
1 parent 7c35b57
commit cdf3509
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 1 deletion.
diff --git a/app/src/main/java/com/bnyro/wallpaper/ui/pages/SettingsPage.kt b/app/src/main/java/com/bnyro/wallpaper/ui/pages/SettingsPage.kt
@@ -20,6 +20,7 @@ import androidx.compose.ui.Modifier
 import androidx.compose.ui.platform.LocalContext
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.unit.dp
+import androidx.work.NetworkType
 import com.bnyro.wallpaper.R
 import com.bnyro.wallpaper.enums.ThemeMode
 import com.bnyro.wallpaper.enums.WallpaperConfig
@@ -138,6 +139,13 @@ fun SettingsPage(
             1440L
         )
 
+        val networkTypes = listOf(
+            R.string.all_networks to NetworkType.CONNECTED,
+            R.string.unmetered to NetworkType.UNMETERED,
+            R.string.metered to NetworkType.METERED,
+            R.string.not_roaming to NetworkType.NOT_ROAMING,
+        )
+
         AboutContainer {
             SettingsCategory(
                 title = stringResource(R.string.wallpaper_changer)
@@ -152,6 +160,15 @@ fun SettingsPage(
             ) {
                 WorkerHelper.enqueue(context, true)
             }
+            ListPreference(
+                prefKey = Preferences.wallpaperChangerNetworkTypeKey,
+                title = stringResource(R.string.network_type),
+                entries = networkTypes.map { stringResource(id = it.first) },
+                values = networkTypes.map { it.second.name },
+                defaultValue = NetworkType.CONNECTED.name
+            ) {
+                WorkerHelper.enqueue(context, true)
+            }
             ListPreference(
                 prefKey = Preferences.wallpaperChangerIntervalKey,
                 title = stringResource(R.string.change_interval),

diff --git a/app/src/main/java/com/bnyro/wallpaper/util/Preferences.kt b/app/src/main/java/com/bnyro/wallpaper/util/Preferences.kt
@@ -24,6 +24,7 @@ object Preferences {
 
     const val wallpaperChangerKey = "wallpaperChanger"
     const val wallpaperChangerIntervalKey = "wallpaperChangerInterval"
+    const val wallpaperChangerNetworkTypeKey = "wallpaperChangerNetworkType"
     private const val wallpaperChangerConfigKey = "wallpaperChangerConfig"
     const val combineWallpaperChangers = "combineWallpaperChangers"
 

diff --git a/app/src/main/java/com/bnyro/wallpaper/util/WorkerHelper.kt b/app/src/main/java/com/bnyro/wallpaper/util/WorkerHelper.kt
@@ -16,7 +16,8 @@ object WorkerHelper {
         val wallpaperConfigs = Preferences.getWallpaperConfigs()
         // only require internet when the source is not local
         val networkType = if (wallpaperConfigs.any { it.source != WallpaperSource.LOCAL }) {
-            NetworkType.CONNECTED
+            val pref = Preferences.getString(Preferences.wallpaperChangerNetworkTypeKey, NetworkType.CONNECTED.name)
+            NetworkType.valueOf(pref)
         } else {
             NetworkType.NOT_REQUIRED
         }

diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -64,6 +64,12 @@
     <string name="none">None</string>
     <string name="invert_wallpaper_by_theme">Invert wallpaper by theme</string>
     <string name="invert_wallpaper_by_theme_summary">Invert the wallpaper to be dark on dark themes and light on light themes.</string>
+    <!-- Network constraints -->
+    <string name="network_type">Network type</string>
+    <string name="all_networks">All networks</string>
+    <string name="unmetered">Unmetered</string>
+    <string name="metered">Metered</string>
+    <string name="not_roaming">Not roaming</string>
     <!-- Wallpaper changer source -->
     <string name="online">Online</string>
     <string name="local">Local</string>