Optimization + Threaded #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yohanchatelain
requested changes
Jun 29, 2021
pytracer/core/parser.py
Outdated
| @@ -130,9 +135,9 @@ def merge_dict(self, args): | |||
| def _merge(self, values, attr, do_not_check=False): | |||
| attrs = None | |||
| if isinstance(attr, str): | |||
| attrs = [value[attr] for value in values] | |||
| attrs = [*map(lambda value: value[attr], values)] | |||
There was a problem hiding this comment.
This rewriting is not faster. Here are my tests:
(10:41) ~:$ python3 -m timeit -n 1000000 -r 5 -v "values = [ {'a':i.upper()} for i in 'abcde' ]; attr = 'a'; attrs = [value[attr] for value in values]"
raw times: 866 msec, 881 msec, 863 msec, 934 msec, 881 msec
1000000 loops, best of 5: 863 nsec per loop
(10:41) ~:$ python3 -m timeit -n 1000000 -r 5 -v "values = [ {'a':i.upper()} for i in 'abcde' ]; attr = 'a'; attrs = [*map(lambda value : value[attr], values)]"
raw times: 1.09 sec, 1.1 sec, 1.09 sec, 1.09 sec, 1.08 sec
Where have you find this optimization?
There was a problem hiding this comment.
Just in general map is faster than for loops. You're right though, list comprehension are faster than map, if it requires a lambda. I will revert the map with lambda back to list comprehension!
pytracer/core/parser.py
Outdated
Comment on lines
560
to
561
| print("STARTING") | ||
| start = time.time() |
There was a problem hiding this comment.
Add an global variable like enable_timer to turn on/off the timer.
pytracer/core/parser.py
Outdated
Comment on lines
558
to
559
| # pr = cProfile.Profile() | ||
| # pr.enable() |
pytracer/core/parser.py
Outdated
Comment on lines
594
to
601
| # pr.disable() | ||
| # pr.print_stats(sort="cumtime") | ||
| # pr.dump_stats("output.prof") | ||
| # | ||
| # stream = open('output.txt', 'w') | ||
| # stats = pstats.Stats('output.prof', stream=stream) | ||
| # stats.sort_stats('cumtime') | ||
| # stats.print_stats() |
pytracer/core/parser.py
Outdated
Comment on lines
591
to
592
| end = time.time() | ||
| print(f"DONE in time: {end - start}") |
There was a problem hiding this comment.
Add an global variable like enable_timer to turn on/off the timer.
pytracer/gui/callbacks.py
Outdated
Comment on lines
426
to
429
| # e1 = time.perf_counter() | ||
| # print("pgc.data.filter x,y", e1-b1) | ||
|
|
||
| b2 = time.perf_counter() | ||
| # b2 = time.perf_counter() |
pytracer/gui/callbacks.py
Outdated
Comment on lines
448
to
451
| # e2 = time.perf_counter() | ||
| # print("extra_value", e2-b2) | ||
|
|
||
| b3 = time.perf_counter() | ||
| # b3 = time.perf_counter() |
pytracer/gui/callbacks.py
Outdated
Comment on lines
464
to
468
| # e3 = time.perf_counter() | ||
| # print("scattergl", b3-e3) | ||
|
|
||
| e = time.perf_counter() | ||
| print("get_scatter_timeline", e-b) | ||
| # e = time.perf_counter() | ||
| # print("get_scatter_timeline", e-b) |
pytracer/gui/callbacks.py
Outdated
Comment on lines
494
to
497
| # e = time.perf_counter() | ||
| # print("add_scatter", e-b) | ||
|
|
||
| # @cache.memoize(timeout=TIMEOUT) |
This was
linked to
issues
Jun 29, 2021
yohanchatelain
approved these changes
Jun 29, 2021
|
@yohanchatelain is it good to be merged now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimization Changes