-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing synchronized blocks with ReentrantLocks in topic-related part of SDK #338
Replacing synchronized blocks with ReentrantLocks in topic-related part of SDK #338
Conversation
…ssageAccumulatorImpl
There was such task in backlog #273 |
There are currently (style) build issues due to trailing spaces in 4 lines in WriterImpl |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #338 +/- ##
============================================
- Coverage 47.34% 47.19% -0.16%
Complexity 1750 1750
============================================
Files 309 311 +2
Lines 12463 12499 +36
Branches 1232 1238 +6
============================================
- Hits 5901 5899 -2
- Misses 6102 6140 +38
Partials 460 460 ☔ View full report in Codecov by Sentry. |
As mentioned in Java's official virtual threads tutorial,
synchonized
blocks reduce benefits of virtual threads'. In this PR, I've replaced allsynchronized
blocks in topic-related part of SDK withReentrantLock
s.