Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getting metadata value from proto #212

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

pnv1
Copy link
Collaborator

@pnv1 pnv1 commented Jan 9, 2024

No description provided.

@pnv1 pnv1 added the bug Something isn't working label Jan 9, 2024
@pnv1 pnv1 requested a review from alex268 January 9, 2024 10:06
@pnv1 pnv1 self-assigned this Jan 9, 2024
@pnv1 pnv1 linked an issue Jan 9, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0e20b2a) 40.23% compared to head (d82b32c) 40.23%.

Files Patch % Lines
...tech/ydb/topic/read/impl/PartitionSessionImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #212   +/-   ##
==========================================
  Coverage      40.23%   40.23%           
  Complexity      1186     1186           
==========================================
  Files            246      246           
  Lines           9697     9697           
  Branches         923      923           
==========================================
  Hits            3902     3902           
  Misses          5527     5527           
  Partials         268      268           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pnv1 pnv1 merged commit 9d6758a into develop Jan 9, 2024
7 checks passed
@pnv1 pnv1 deleted the fix_message_metadata_value branch January 9, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Topics: Add message metadata support
3 participants