Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for reading without a consumer #211

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Conversation

pnv1
Copy link
Collaborator

@pnv1 pnv1 commented Jan 9, 2024

No description provided.

@pnv1 pnv1 added the enhancement New feature or request label Jan 9, 2024
@pnv1 pnv1 requested a review from alex268 January 9, 2024 10:03
@pnv1 pnv1 self-assigned this Jan 9, 2024
@pnv1 pnv1 linked an issue Jan 9, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (0e20b2a) 40.23% compared to head (ace33b8) 40.20%.

Files Patch % Lines
...n/java/tech/ydb/topic/settings/ReaderSettings.java 0.00% 7 Missing ⚠️
...main/java/tech/ydb/topic/read/impl/ReaderImpl.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #211      +/-   ##
=============================================
- Coverage      40.23%   40.20%   -0.04%     
  Complexity      1186     1186              
=============================================
  Files            246      246              
  Lines           9697     9706       +9     
  Branches         923      927       +4     
=============================================
  Hits            3902     3902              
- Misses          5527     5536       +9     
  Partials         268      268              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pnv1 pnv1 merged commit 45472d5 into develop Jan 10, 2024
7 checks passed
@pnv1 pnv1 deleted the read_without_consumer branch January 10, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Topics: Support reading from topic without a consumer
3 participants