Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use offsets from StartPartitionSessionResponse in first message commit offsets #199

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

pnv1
Copy link
Collaborator

@pnv1 pnv1 commented Nov 20, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (7e091ee) 39.61% compared to head (6bbd3ae) 39.56%.

Files Patch % Lines
...main/java/tech/ydb/topic/read/impl/ReaderImpl.java 0.00% 17 Missing ⚠️
...tech/ydb/topic/read/impl/PartitionSessionImpl.java 0.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #199      +/-   ##
=============================================
- Coverage      39.61%   39.56%   -0.05%     
  Complexity      1159     1159              
=============================================
  Files            244      244              
  Lines           9587     9599      +12     
  Branches         918      918              
=============================================
  Hits            3798     3798              
- Misses          5523     5535      +12     
  Partials         266      266              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pnv1 pnv1 merged commit 850a5ec into develop Nov 20, 2023
7 checks passed
@pnv1 pnv1 deleted the issue_198 branch November 20, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants