Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add topic message DeferredCommitter, remove redundant data references #189

Merged
merged 7 commits into from
Oct 26, 2023

Conversation

pnv1
Copy link
Collaborator

@pnv1 pnv1 commented Oct 19, 2023

No description provided.

@pnv1 pnv1 requested a review from alex268 October 19, 2023 10:22
@pnv1 pnv1 self-assigned this Oct 19, 2023
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (fbefb8f) 51.90% compared to head (f9d1cae) 51.90%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #189   +/-   ##
==========================================
  Coverage      51.90%   51.90%           
  Complexity      1139     1139           
==========================================
  Files            179      179           
  Lines           7233     7233           
  Branches         723      723           
==========================================
  Hits            3754     3754           
  Misses          3213     3213           
  Partials         266      266           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pnv1 pnv1 changed the title Add topic message Committer, remove data references where possible Add topic message DeferredCommitter, remove redundant data references Oct 26, 2023
@pnv1 pnv1 merged commit bca9e3d into develop Oct 26, 2023
7 checks passed
@pnv1 pnv1 deleted the add_committer_to_topic_messages branch October 26, 2023 15:24
@pnv1 pnv1 linked an issue Oct 26, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Topics: Add DeferredCommitter to accumulate offset ranges to commit later
3 participants