Merge pull request #349 from ydb-platform/improve-reader-logging

Remove "This shouldn't happen" from topic reader logs where it can actually happen
ydb-platform · Dec 5, 2024 · 2984ceb · 2984ceb
2 parents fbcf72a + f67f748
commit 2984ceb
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/topic/src/main/java/tech/ydb/topic/read/impl/ReaderImpl.java b/topic/src/main/java/tech/ydb/topic/read/impl/ReaderImpl.java
@@ -456,9 +456,8 @@ private void onReadResponse(YdbTopic.StreamReadMessage.ReadResponse readResponse
                             CompletableFuture<Void> readFuture = partitionSession.addBatches(data.getBatchesList());
                             batchReadFutures.add(readFuture);
                         } else {
-                            logger.error("[{}] Received PartitionData for unknown(closed?) PartitionSessionId={}. " +
-                                            "This shouldn't happen",
-                                    fullId, partitionId);
+                            logger.info("[{}] Received PartitionData for unknown(most likely already closed) " +
+                                            "PartitionSessionId={}", fullId, partitionId);
                         }
                     });
             CompletableFuture.allOf(batchReadFutures.toArray(new CompletableFuture<?>[0]))
@@ -491,8 +490,8 @@ protected void onCommitOffsetResponse(YdbTopic.StreamReadMessage.CommitOffsetRes
                     handleCommitResponse(partitionCommittedOffset.getCommittedOffset(),
                             partitionSession.getSessionInfo());
                 } else {
-                    logger.error("[{}] Received CommitOffsetResponse for unknown (closed?) partition session with " +
-                                    "id={}. This shouldn't happen", fullId,
+                    logger.info("[{}] Received CommitOffsetResponse for unknown (most likely already closed) " +
+                                    "partition session with id={}", fullId,
                             partitionCommittedOffset.getPartitionSessionId());
                 }
             }