Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend metric callbacks #902

Merged
merged 5 commits into from
Dec 13, 2023
Merged

extend metric callbacks #902

merged 5 commits into from
Dec 13, 2023

Conversation

notanonymousenough
Copy link
Contributor

@notanonymousenough notanonymousenough commented Dec 5, 2023

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

There are not enough metrics and statuses

Issue Number: N/A

What is the new behavior?

  • added callbacks in database.sql metrics
  • added TLI error recognition

Other information

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (aec710b) 66.80% compared to head (ffcc66b) 66.83%.

Files Patch % Lines
metrics/error_brief.go 0.00% 2 Missing and 1 partial ⚠️
metrics/sql.go 95.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #902      +/-   ##
==========================================
+ Coverage   66.80%   66.83%   +0.03%     
==========================================
  Files         258      258              
  Lines       24582    24618      +36     
==========================================
+ Hits        16422    16454      +32     
- Misses       7316     7319       +3     
- Partials      844      845       +1     
Flag Coverage Δ
53.61% <90.19%> (+0.06%) ⬆️
go-1.17.x 65.23% <0.00%> (+<0.01%) ⬆️
go-1.20.x 66.13% <90.19%> (-0.57%) ⬇️
go-1.21.x 66.70% <90.19%> (-0.07%) ⬇️
integration 53.61% <90.19%> (+0.06%) ⬆️
macOS 38.69% <0.00%> (-0.09%) ⬇️
ubuntu 38.75% <0.00%> (-0.03%) ⬇️
unit 38.83% <0.00%> (-0.07%) ⬇️
windows 38.47% <0.00%> (-0.41%) ⬇️
ydb-22.5 53.22% <90.19%> (+0.06%) ⬆️
ydb-23.1 53.25% <90.19%> (+0.08%) ⬆️
ydb-23.2 53.04% <90.19%> (-0.27%) ⬇️
ydb-23.3 53.29% <90.19%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

(cherry picked from commit bba76dc)
(cherry picked from commit 9b58dd0)
(cherry picked from commit 4c51b3f)
(cherry picked from commit c993b19)
@asmyasnikov asmyasnikov merged commit f1d4f44 into ydb-platform:master Dec 13, 2023
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants