Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flacky tests #901

Merged
merged 18 commits into from
Dec 12, 2023
Merged

Fix flacky tests #901

merged 18 commits into from
Dec 12, 2023

Conversation

rekby
Copy link
Member

@rekby rekby commented Dec 5, 2023

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

fix topic's flacky tests

Copy link

github-actions bot commented Dec 5, 2023

summary

Base version: v3.54.3-0.20231212144334-12f3818a0c41 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.54.2.

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3c08fa3) 66.85% compared to head (4f9a350) 66.81%.
Report is 8 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #901      +/-   ##
==========================================
- Coverage   66.85%   66.81%   -0.04%     
==========================================
  Files         258      258              
  Lines       24527    24582      +55     
==========================================
+ Hits        16397    16424      +27     
- Misses       7288     7319      +31     
+ Partials      842      839       -3     
Flag Coverage Δ
53.64% <ø> (+0.07%) ⬆️
go-1.17.x 65.35% <ø> (+0.10%) ⬆️
go-1.20.x 66.55% <ø> (-0.08%) ⬇️
go-1.21.x 66.67% <ø> (-0.01%) ⬇️
integration 53.64% <ø> (+0.07%) ⬆️
macOS 38.84% <ø> (+<0.01%) ⬆️
ubuntu 38.84% <ø> (-0.03%) ⬇️
unit 38.93% <ø> (-0.02%) ⬇️
windows 38.88% <ø> (-0.04%) ⬇️
ydb-22.5 53.04% <ø> (-0.22%) ⬇️
ydb-23.1 53.03% <ø> (-0.08%) ⬇️
ydb-23.2 53.27% <ø> (+0.01%) ⬆️
ydb-23.3 53.18% <ø> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 5, 2023

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

github-actions bot commented Dec 5, 2023

🌋 Here are results of SLO test for Go SDK native:

Grafana Dashboard

SLO-native

Copy link

github-actions bot commented Dec 5, 2023

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

Copy link

github-actions bot commented Dec 5, 2023

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-databasesql

@rekby rekby self-assigned this Dec 8, 2023
@rekby rekby changed the title add test logs Fix flacky tests Dec 8, 2023
@rekby rekby added the no slo label Dec 8, 2023
@rekby rekby marked this pull request as ready for review December 12, 2023 15:16
@rekby rekby merged commit d0200c5 into master Dec 12, 2023
49 checks passed
@asmyasnikov asmyasnikov deleted the 741-fix-flacky-tests branch March 5, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants