Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to fail SLO tests #900

Merged
merged 1 commit into from
Nov 25, 2023
Merged

allow to fail SLO tests #900

merged 1 commit into from
Nov 25, 2023

Conversation

rekby
Copy link
Member

@rekby rekby commented Nov 24, 2023

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

Copy link

summary

Base version: v3.54.3-0.20231115182119-3c08fa394e44 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.54.2.

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3c08fa3) 66.85% compared to head (07c2c0c) 66.82%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #900      +/-   ##
==========================================
- Coverage   66.85%   66.82%   -0.04%     
==========================================
  Files         258      258              
  Lines       24527    24527              
==========================================
- Hits        16397    16389       -8     
- Misses       7288     7296       +8     
  Partials      842      842              
Flag Coverage Δ
53.52% <ø> (-0.05%) ⬇️
go-1.17.x 65.36% <ø> (+0.12%) ⬆️
go-1.20.x 66.68% <ø> (+0.05%) ⬆️
go-1.21.x 66.60% <ø> (-0.07%) ⬇️
integration 53.52% <ø> (-0.05%) ⬇️
macOS 38.88% <ø> (+0.04%) ⬆️
ubuntu 38.87% <ø> (-0.01%) ⬇️
unit 38.97% <ø> (+0.02%) ⬆️
windows 38.94% <ø> (+0.02%) ⬆️
ydb-22.5 53.14% <ø> (-0.12%) ⬇️
ydb-23.1 53.39% <ø> (+0.28%) ⬆️
ydb-23.2 53.33% <ø> (+0.07%) ⬆️
ydb-23.3 53.25% <ø> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rekby rekby marked this pull request as ready for review November 24, 2023 14:14
@rekby rekby closed this Nov 24, 2023
@rekby rekby reopened this Nov 24, 2023
@rekby rekby marked this pull request as draft November 24, 2023 14:14
@rekby rekby marked this pull request as ready for review November 24, 2023 15:55
@asmyasnikov asmyasnikov merged commit 863b2aa into master Nov 25, 2023
96 checks passed
@asmyasnikov asmyasnikov deleted the ignore-slo-fail branch November 25, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants