Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Added and Dropped fields into balancer update done info #892

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

asmyasnikov
Copy link
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@asmyasnikov asmyasnikov self-assigned this Nov 10, 2023
Copy link

github-actions bot commented Nov 10, 2023

github.com/ydb-platform/ydb-go-sdk/v3/trace

incompatible changes

DriverOnBalancerUpdate: changed from func(*Driver, *context.Context, call, bool) func(endpoints []EndpointInfo, localDC string, _ error) to func(*Driver, *context.Context, call, bool) func(endpoints []EndpointInfo, added []EndpointInfo, dropped []EndpointInfo, localDC string, _ error)

compatible changes

DriverBalancerUpdateDoneInfo.Added: added
DriverBalancerUpdateDoneInfo.Dropped: added

summary

Base version: v3.54.2-rc2 (master)
Suggested version: v3.54.2

@asmyasnikov asmyasnikov force-pushed the added-dropped branch 3 times, most recently from cb95965 to 9f6f344 Compare November 10, 2023 10:49
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6373d76) 66.81% compared to head (e3e3bd5) 66.81%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #892   +/-   ##
=======================================
  Coverage   66.81%   66.81%           
=======================================
  Files         258      258           
  Lines       24319    24353   +34     
=======================================
+ Hits        16249    16272   +23     
- Misses       7233     7245   +12     
+ Partials      837      836    -1     
Flag Coverage Δ
53.42% <73.91%> (-0.03%) ⬇️
go-1.17.x 65.24% <95.65%> (-0.06%) ⬇️
go-1.20.x 66.71% <95.65%> (+0.24%) ⬆️
go-1.21.x 66.71% <95.65%> (+0.27%) ⬆️
integration 53.42% <73.91%> (-0.03%) ⬇️
macOS 38.97% <80.43%> (+0.09%) ⬆️
ubuntu 38.98% <80.43%> (+0.05%) ⬆️
unit 39.08% <80.43%> (+0.06%) ⬆️
windows 39.03% <80.43%> (+0.03%) ⬆️
ydb-22.5 53.15% <73.91%> (+0.18%) ⬆️
ydb-23.1 52.96% <73.91%> (-0.21%) ⬇️
ydb-23.2 53.01% <73.91%> (+<0.01%) ⬆️
ydb-23.3 53.05% <73.91%> (+1.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
log/driver.go 65.87% <100.00%> (+0.16%) ⬆️
internal/balancer/balancer.go 84.75% <95.45%> (+2.05%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 10, 2023

🌋 Here are results of SLO test for Go SDK native:

Grafana Dashboard

SLO-native

Copy link

github-actions bot commented Nov 10, 2023

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-databasesql

Copy link

github-actions bot commented Nov 10, 2023

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

github-actions bot commented Nov 10, 2023

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

@asmyasnikov asmyasnikov merged commit 1ba3a4d into master Nov 10, 2023
48 of 49 checks passed
@asmyasnikov asmyasnikov deleted the added-dropped branch November 10, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants